feat(*): add custom target for popup in dropdown #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleksandr-konovalov
requested review from
Arinteck,
stepancar,
artptr,
ivliag and
ziimir
|
Какое-то странное направление, типа Юго-Север. Можешь пример закинуть, скрин? |
|
|
|
Так это |
|
Нет, это popup для мобилки =) |
|
Чем это отличается от target='screen'? |
|
Кажется, что ничем, но в dropdown почему-то нельзя указать 'screen' для popup. |
|
Ну так и добавить в него screen. |
aleksandr-konovalov
force-pushed
the
feat/add-new-direction
branch
from
b0e540e
to
228b52e
Compare
|
Ок, приделал |
|
Нужно коммит назвать по гайдлайну. |
GREENpoint
previously approved these changes
Nov 17, 2017
aleksandr-konovalov
changed the title
aleksandr-konovalov
force-pushed
the
feat/add-new-direction
branch
from
228b52e
to
2176573
Compare
artptr
approved these changes
Nov 17, 2017
tx44
approved these changes
Nov 17, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add custom target for popup in dropdown
Мотивация и контекст
Для того, чтобы попап растянуть на полный экран в мобилках.