Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IONOS Cleanup #11

Open
jackc94 opened this issue Jan 29, 2024 · 5 comments
Open

IONOS Cleanup #11

jackc94 opened this issue Jan 29, 2024 · 5 comments

Comments

@jackc94
Copy link

jackc94 commented Jan 29, 2024

It would be great if the TXT entry was cleaned up after the certs are issued... I know IONOS supports this through the API.

Looks like it might be thinning about it from the logs but the TXT entry remains...

2024-01-29 23:50:38,317:DEBUG:acme.client:Storing nonce: < nonce> 2024-01-29 23:50:38,318:DEBUG:certbot._internal.error_handler:Calling registered functions 2024-01-29 23:50:38,319:INFO:certbot._internal.auth_handler:Cleaning up challenges 2024-01-29 23:50:38,321:DEBUG:certbot_dns_multi._internal.dns_multi:Asking lego to clean up record <record> for domain <mydomain.co.uk>

@alexzorin
Copy link
Owner

If you can confirm that:

  1. lego by itself does the cleanup properly
  2. This plugin doesn't

I will be able to investigate.

Thanks.

@jackc94
Copy link
Author

jackc94 commented Jan 30, 2024

Hi @alexzorin

Thanks for getting back to me so quickly. Ok... so I have tested this directly with lego and can confirm that it DOES NOT clean up so will raise an issue directly.

Thanks for your help,

Jack

@jackc94
Copy link
Author

jackc94 commented Jan 31, 2024

Hey @alexzorin

So it looks like this was resolved in v4.15.0 of lego here go-acme/lego#2083

Is this something you bundle with certbot-dns-multi? Apologies, not sure how these things work...

@alexzorin
Copy link
Owner

alexzorin commented Jan 31, 2024

Thanks for figuring out the relevant issue.

I actually released a new version of the plugin yesterday that uses the latest release of lego (v4.15.0), so if you update, it should be working for you now.

If you use the snap, you might need to run snap refresh.

@jackc94
Copy link
Author

jackc94 commented Feb 1, 2024

@alexzorin BINGO!

That's great news... looking forward to implementing this now.

Keep up the great work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants