feat: add option to configure flutter mode via config #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It will add possibility to run app in `profile`, `release` modes.
1 task
akinsho
reviewed
Dec 18, 2023
| }, | ||
| { | ||
| name = 'Profile', | ||
| flutter_mode = 'profile', -- possible values: `debug`, `profile` or `release`, defaults to `debug` |
There was a problem hiding this comment.
Does this need to be prefixed with flutter_ or can it just be mode or is it flutter_ mode vs something like dart_mode (but not heard of that, but decidedly out of the loop atm)
There was a problem hiding this comment.
Yea, naming is always difficult :)
I think it may be just mode or build_mode, as in docs: 'https://docs.flutter.dev/testing/build-modes'
flutter_mode was used to align with VSCode property flutterMode https://docs.flutter.dev/tools/vs-code#run-app-in-debug-profile-or-release-mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will add possibility to run app in
profile,releasemodes.