Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build.xml files don't take into account jdk14 new naming convention #1610

Closed
adam-thorpe opened this issue Feb 12, 2020 · 3 comments
Closed
Labels
Milestone

Comments

@adam-thorpe
Copy link
Contributor

New jdk14 repo for hotspot builds is at https://github.com/AdoptOpenJDK/openjdk-jdk14, not jdk14u, so build.xml scripts cannot find it.

Eg.

git clone --depth 1 -q -b dev https://github.com/AdoptOpenJDK/openjdk-jdk14u.git
@adam-thorpe
Copy link
Contributor Author

I have a quick fix for this, but because you can't do integer comparisons in xml, we would have to manually check for each version past 14

@smlambert
Copy link
Contributor

I am presuming you can add a check in this block, so that if:
<IsLessThan arg1="${JDK_VERSION}" arg2="14" /> then append 'u'

@karianna
Copy link
Contributor

Yep we typically move to the u naming once the version goes GA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants