-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reject a faulty delivery logic #147
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -513,6 +513,46 @@ func TestReturnRejected(t *testing.T) { | |
eventuallyRejected(t, queue, 0) | ||
} | ||
|
||
func TestRejectFaultyMessages(t *testing.T) { | ||
redisAddr, closer := testRedis(t) | ||
defer closer() | ||
|
||
connection, err := OpenConnection("faulty-conn", "tcp", redisAddr, 1, nil) | ||
require.NoError(t, err) | ||
queue, err := connection.OpenQueue("faulty-q") | ||
require.NoError(t, err) | ||
_, err = queue.PurgeReady() | ||
require.NoError(t, err) | ||
|
||
for i := 0; i < 6; i++ { | ||
// if there is no line separator after the header in the message, | ||
// it will lead to an error and the message will be rejected | ||
err := queue.Publish(fmt.Sprintf("%sreturn-d%d", jsonHeaderSignature, i)) | ||
require.NoError(t, err) | ||
} | ||
|
||
eventuallyReady(t, queue, 6) | ||
eventuallyUnacked(t, queue, 0) | ||
eventuallyRejected(t, queue, 0) | ||
|
||
require.NoError(t, queue.StartConsuming(10, time.Millisecond)) | ||
eventuallyReady(t, queue, 0) | ||
eventuallyUnacked(t, queue, 0) | ||
eventuallyRejected(t, queue, 6) | ||
|
||
consumer := NewTestConsumer("faulty-cons") | ||
consumer.AutoAck = false | ||
_, err = queue.AddConsumer("cons", consumer) | ||
require.NoError(t, err) | ||
eventuallyReady(t, queue, 0) | ||
eventuallyUnacked(t, queue, 0) | ||
eventuallyRejected(t, queue, 6) | ||
|
||
require.Len(t, consumer.Deliveries(), 0) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am not sure if it's correct. I want to figure out why we have no deliveries. They should be rejected. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, I double-checked. This is an expected behaviour, we don't push those deliveries into the delivery channel. |
||
|
||
<-queue.StopConsuming() | ||
} | ||
|
||
func TestPushQueue(t *testing.T) { | ||
redisAddr, closer := testRedis(t) | ||
defer closer() | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, thank you! It was a bug!