Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consume: use jittered poll duration in all cases #117

Merged
merged 1 commit into from
Mar 21, 2022
Merged

consume: use jittered poll duration in all cases #117

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions queue.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,9 +178,8 @@ func (queue *redisQueue) consume() {
case queue.errChan <- &ConsumeError{RedisErr: err, Count: errorCount}:
default:
}

time.Sleep(jitteredDuration(queue.pollDuration))
}
time.Sleep(jitteredDuration(queue.pollDuration))
}
}

Expand All @@ -199,8 +198,6 @@ func (queue *redisQueue) consumeBatch() error {

batchSize := queue.prefetchLimit - unackedCount
if batchSize <= 0 {
// already at prefetch limit, wait for consumers to finish
time.Sleep(queue.pollDuration) // sleep before retry
return nil
}

Expand All @@ -213,8 +210,6 @@ func (queue *redisQueue) consumeBatch() error {

payload, err := queue.redisClient.RPopLPush(queue.readyKey, queue.unackedKey)
if err == ErrorNotFound {
// ready list currently empty, wait for new deliveries
time.Sleep(queue.pollDuration)
return nil
}

Expand Down Expand Up @@ -540,6 +535,6 @@ func (queue *redisQueue) ensureConsuming() error {

// jitteredDuration calculates and returns a value that is +/-10% the input duration
func jitteredDuration(duration time.Duration) time.Duration {
factor := 0.9 + randSrc.Float64() * 0.2 // a jitter factor between 0.9 and 1.1 (+-10%)
factor := 0.9 + randSrc.Float64()*0.2 // a jitter factor between 0.9 and 1.1 (+-10%)
return time.Duration(float64(duration) * factor)
}