Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't take tab width into account #11

Closed
emichael opened this issue Sep 10, 2015 · 6 comments
Closed

Doesn't take tab width into account #11

emichael opened this issue Sep 10, 2015 · 6 comments

Comments

@emichael
Copy link

I use tabs in Java, and I have the tab-width set to 4 in my settings. Wrap to column doesn't respect this and wraps past the end of the right margin. Not sure if it's considering tabs as 1 character or two, though.

@abrookins
Copy link
Owner

Thank you, @emichael! I hope to look into this when I have time for another round of fixes.

@abrookins
Copy link
Owner

@emichael I'm still not sure what to do about tabs. Since tabs have a variable display width, couldn't you reflow a paragraph that works for your tab-width setting, only to have a coworker whose tab-width is different complain that the lines are over the margin for them? As a tab user, what would you most expect the plugin to do -- use your configured tab-width is?

@emichael
Copy link
Author

emichael commented Dec 7, 2015

Yes. Members of the same project should all be using an agreed upon tab-width, anyways. Besides, you're always going to have that problem (that people can use different tab-widths), and making the plugin respect the current configuration is strictly better than it assuming some set value.

@abrookins
Copy link
Owner

Ok, I'm convinced, and thank you again for taking the time to report. This is next up on my list.

@abrookins
Copy link
Owner

@emichael I made a Github release with my attempt to fix this issue: https://github.com/abrookins/WrapToColumn/releases/tag/1.2.0 in case you want to try it out before I release through Jetbrains.

@emichael
Copy link
Author

Thanks! I don't have time to test it right now, unfortunately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants