Fix/keystore

[edison0xyz]

The following error was thrown in the Keystore

# github.com/Zilliqa/gozilliqa-sdk/crypto
../../Zilliqa/gozilliqa-sdk/crypto/keystore.go:185:22: multiple-value uuid.NewV4() in single-value context

Issue has similarly being raised here. satori/go.uuid#106. Looks like the function now returns multiple values, which broke the implementation. I've just made a hack and it works.

To decide

Should we stop using this dependency (https://github.com/satori/go.uuid) since it was last maintained in 2018? I saw that you are using "github.com/google/uuid" under the workpool package. I looked through briefly and I think it can replace this repository since it also follows the RFC 4122 standard.

The original repo is dead, and someone tried to create a fork https://github.com/gofrs/uuid which is also dead.

Thoughts, @renlulu?

System

go version 1.14.2

[renlulu]

Many thanks for the fix, yes, it's fine to me to use github.com/google/uuid to replace github.com/satori/go.uuid, would you like to do it in this PR xD

[edison0xyz]

Many thanks for the fix, yes, it's fine to me to use github.com/google/uuid to replace github.com/satori/go.uuid, would you like to do it in this PR xD

Sure will do. Will get this out in a bit. Don't merge the PR first.

[renlulu]

Many thanks for the fix, yes, it's fine to me to use github.com/google/uuid to replace github.com/satori/go.uuid, would you like to do it in this PR xD

Sure will do. Will get this out in a bit. Don't merge the PR first.

OK, thanks!