Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log_deprecated_pkg: fix compilation issues with Cadence tools #731

Merged
merged 1 commit into from
Aug 31, 2021

Conversation

umarcor
Copy link
Member

@umarcor umarcor commented Aug 30, 2021

This PR picks a commit from #684, which is required according to #728.

/cc @powARman @rodrigomelo9

@LarsAsplund
Copy link
Collaborator

I think it's time to remove this deprecated stuff altogether now that we're about to make a new major release

@LarsAsplund LarsAsplund merged commit 3e5613a into VUnit:master Aug 31, 2021
@umarcor umarcor deleted the fix-deprecated-log branch August 31, 2021 13:02
@umarcor
Copy link
Member Author

umarcor commented Aug 31, 2021

@LarsAsplund, agree. However, we have two major changes coming up:

  1. Addition of the "rule based" VC plumbing.
  2. Moving some VCs to separated repos and submoduling them.

I think that we might want to release v4.6.0 after 1, and v5.0.0 after 2. We, might deprecate stuff between those. Alternativaly, we could bump to v5.0.0, but then maybe we should go to v6.0.0 to be semver compliant. That is because, strictly, reworking the VCs in a backwards incompatible way is ok, as long as those are in Beta. However, deprecations and submoduling forces a major version bump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants