feat: 마이페이지 svg 이미지 png 적용 및 s3 로직 적용 #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeonjeen
approved these changes
Sep 26, 2024
| binding.ivMyPageUserProfile.load(updatedMyProfileImageUrl) { | ||
| crossfade(true) | ||
| error(R.drawable.img_loading_thumbnail) | ||
| transformations(CircleCropTransformation()) |
| data class MyPageUiState( | ||
| val loading: Boolean = false, | ||
| val error: Boolean = false, | ||
| val myProfile: MyProfileEntity? = null |
There was a problem hiding this comment.
앗 트레일링콤마 빠졌어요!!!(아싸 나도 찾았다)
s9hn
approved these changes
Sep 26, 2024
| private fun setupObserver() { | ||
| myPageViewModel.myPageUiState.observe(viewLifecycleOwner) { uiState -> | ||
| when { | ||
| !uiState.loading -> setUpMyProfileImage(uiState.myProfile?.avatarImage ?: "") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌𝘐𝘴𝘴𝘶𝘦𝘴
📎𝘞𝘰𝘳𝘬 𝘋𝘦𝘴𝘤𝘳𝘪𝘱𝘵𝘪𝘰𝘯
📷𝘚𝘤𝘳𝘦𝘦𝘯𝘴𝘩𝘰𝘵
Screen_recording_20240926_150455.mp4
💬𝘛𝘰 𝘙𝘦𝘷𝘪𝘦𝘸𝘦𝘳𝘴
마이페이지도 이제 그럴듯하네요