Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 다른 유저 서재 ui 구현 및 api 연결 #270

Merged
merged 6 commits into from
Aug 29, 2024
Merged

Conversation

yeonjeen
Copy link
Contributor

@yeonjeen yeonjeen commented Aug 29, 2024

📌𝘐𝘴𝘴𝘶𝘦𝘴

📎𝘞𝘰𝘳𝘬 𝘋𝘦𝘴𝘤𝘳𝘪𝘱𝘵𝘪𝘰𝘯

  • 보관함, 장르취향, 작품 취향 ui
  • 데이터 바인딩 적용
  • 보관함 카운트, 장르취향, 작품취향 api 연결

📷𝘚𝘤𝘳𝘦𝘦𝘯𝘴𝘩𝘰𝘵

KakaoTalk_Video_2024-08-30-00-22-32.mp4

💬𝘛𝘰 𝘙𝘦𝘷𝘪𝘦𝘸𝘦𝘳𝘴

제가 재사용을 하고 싶었는데욤.. 바인딩 문제로 계속 작업이 진행이 안되서.. 이렇게 하게 되었습니다..(꾸벅)
이렇게 하면 안될까요..ㅜㅜ

그래서 일단 코드는 마이페이지 서재와 변수명만 다르고 완전히 똑같습니다..!

@yeonjeen yeonjeen added 🍯 [FEAT] 새로운 기능을 개발합니다. 👛 황후 연진 어느날 웹소소의 황후가 되어버렸다 labels Aug 29, 2024
@yeonjeen yeonjeen requested a review from a team August 29, 2024 15:25
@yeonjeen yeonjeen self-assigned this Aug 29, 2024
Copy link
Contributor

@m6z1 m6z1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

전체적으로 LinearLayout > ll로 id값 사용ㅎㅐ주시면 될 것 같아요!
코멘트 반영만 해주세염 >0<

import com.teamwss.websoso.databinding.ItemRestGenreBinding

class RestGenrePreferenceAdapter(
items: List<GenrePreferenceEntity> = emptyList(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c: 어댑터의 생성자로 아이템을 넘겨주어야 하나용?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

어댑터가 데이터를 가지고 있어야 뷰를 만들고 바인딩 할 수 있어서 넘겨주고 있습니당...!

app/src/main/res/layout/fragment_other_user_library.xml Outdated Show resolved Hide resolved
app/src/main/res/layout/fragment_other_user_library.xml Outdated Show resolved Hide resolved
app/src/main/res/layout/fragment_other_user_library.xml Outdated Show resolved Hide resolved
app/src/main/res/layout/fragment_other_user_library.xml Outdated Show resolved Hide resolved
Copy link
Member

@junseo511 junseo511 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생티비

Comment on lines 19 to 20
) :
ViewModel() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c: 줄바꿈하신 이유가 있으신지?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1시간 전 연진이 맘(이지만 수정 했슴당 ㅎ)

}

private fun getUserId(): Long {
return 1L
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c: 여기 왜 1L이 고정인가요?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다른유저 프로필 경우는 피드에서 프로필을 눌렀을 때 넘어오는거라서 그때 넘겨 받을 예정입니다!

app/src/main/res/layout/fragment_other_user_library.xml Outdated Show resolved Hide resolved
@yeonjeen yeonjeen merged commit fee70d4 into develop Aug 29, 2024
@librarywon librarywon deleted the feat/238 branch September 11, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍯 [FEAT] 새로운 기능을 개발합니다. 👛 황후 연진 어느날 웹소소의 황후가 되어버렸다
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: 다른유저페이지 서재 구현
3 participants