Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 마이페이지 프로필 및 내 서재 api 연결 #262

Merged
merged 21 commits into from
Aug 29, 2024
Merged

Conversation

yeonjeen
Copy link
Contributor

📌𝘐𝘴𝘴𝘶𝘦𝘴

📎𝘞𝘰𝘳𝘬 𝘋𝘦𝘴𝘤𝘳𝘪𝘱𝘵𝘪𝘰𝘯

  • 프로필 api 연결
  • 보관함 카운트 api 연결
  • 장르선호 api 연결
  • 작품선호 api 연결

📷𝘚𝘤𝘳𝘦𝘦𝘯𝘴𝘩𝘰𝘵

KakaoTalk_Video_2024-08-29-16-14-30.mp4

💬𝘛𝘰 𝘙𝘦𝘷𝘪𝘦𝘸𝘦𝘳𝘴

@yeonjeen yeonjeen added 🍯 [FEAT] 새로운 기능을 개발합니다. 👛 황후 연진 어느날 웹소소의 황후가 되어버렸다 labels Aug 29, 2024
@yeonjeen yeonjeen requested a review from a team August 29, 2024 07:14
@yeonjeen yeonjeen self-assigned this Aug 29, 2024
Copy link
Contributor

@m6z1 m6z1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

트레일링 콤마가 대부분 적용이 안 되어있는데 확인 한 번만 해주시구
빠른 작업을 위해 어프루브 드리겠슴다!!

Copy link
Contributor

@librarywon librarywon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다! 리뷰확인해주세요!

Comment on lines +78 to 80
private fun getUserId(): Long {
return 1L
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c: 이거는 추후에 바뀌는 로직인가요?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵넵

@@ -282,15 +282,15 @@
android:id="@+id/iv_my_library_dominant_genre_first_logo"
android:layout_width="30dp"
android:layout_height="37dp"
android:src="@drawable/ic_novel_detail_genre_test"
app:loadImageUrl="@{myLibraryViewModel.topGenres[0].genreImage}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r: 이건 테스트 이미지를 넣어둔건가요?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

기존에는 테스트 이미지였는데 지금응ㄴ 서버에서 내려주는 이미지입니다!

Copy link
Contributor

@librarywon librarywon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

@yeonjeen yeonjeen merged commit 5c989f1 into develop Aug 29, 2024
@librarywon librarywon deleted the feat/240 branch September 11, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍯 [FEAT] 새로운 기능을 개발합니다. 👛 황후 연진 어느날 웹소소의 황후가 되어버렸다
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: 마이페이지 프로필 및 내 서재 api 연결
3 participants