-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 마이페이지 프로필 및 내 서재 api 연결 #262
Conversation
# Conflicts: # app/src/main/res/values/strings.xml
# Conflicts: # app/src/main/res/values/strings.xml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
트레일링 콤마가 대부분 적용이 안 되어있는데 확인 한 번만 해주시구
빠른 작업을 위해 어프루브 드리겠슴다!!
app/src/main/java/com/teamwss/websoso/data/mapper/UserMapper.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/teamwss/websoso/data/mapper/UserMapper.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/teamwss/websoso/data/mapper/UserMapper.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/teamwss/websoso/data/mapper/UserMapper.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/teamwss/websoso/data/model/MyProfileEntity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/teamwss/websoso/ui/main/myPage/MyPageViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/teamwss/websoso/ui/main/myPage/myLibrary/MyLibraryViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/teamwss/websoso/ui/main/myPage/myLibrary/MyLibraryViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/teamwss/websoso/ui/main/myPage/myLibrary/MyLibraryViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/teamwss/websoso/ui/main/myPage/myLibrary/MyLibraryViewModel.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다! 리뷰확인해주세요!
app/src/main/java/com/teamwss/websoso/data/mapper/UserMapper.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/teamwss/websoso/data/mapper/UserMapper.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/teamwss/websoso/data/remote/api/UserApi.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/teamwss/websoso/ui/main/myPage/myLibrary/MyLibraryViewModel.kt
Show resolved
Hide resolved
private fun getUserId(): Long { | ||
return 1L | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
c: 이거는 추후에 바뀌는 로직인가요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵넵
@@ -282,15 +282,15 @@ | |||
android:id="@+id/iv_my_library_dominant_genre_first_logo" | |||
android:layout_width="30dp" | |||
android:layout_height="37dp" | |||
android:src="@drawable/ic_novel_detail_genre_test" | |||
app:loadImageUrl="@{myLibraryViewModel.topGenres[0].genreImage}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r: 이건 테스트 이미지를 넣어둔건가요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
기존에는 테스트 이미지였는데 지금응ㄴ 서버에서 내려주는 이미지입니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다!
📌𝘐𝘴𝘴𝘶𝘦𝘴
📎𝘞𝘰𝘳𝘬 𝘋𝘦𝘴𝘤𝘳𝘪𝘱𝘵𝘪𝘰𝘯
📷𝘚𝘤𝘳𝘦𝘦𝘯𝘴𝘩𝘰𝘵
KakaoTalk_Video_2024-08-29-16-14-30.mp4
💬𝘛𝘰 𝘙𝘦𝘷𝘪𝘦𝘸𝘦𝘳𝘴