refactor: 피드 조회 뷰 api 수정 #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junseo511
approved these changes
Aug 18, 2024
Comment on lines
+28
to
+29
| @SerialName("title") | ||
| val title: String?, |
| @@ -16,6 +16,7 @@ data class FeedModel( | |||
| val categories: String = relevantCategories.joinToString(prefix = "", postfix = ""), | |||
| ) { | |||
| val formattedCreatedDate: String = " · $createdDate" | |||
| val isEmptyOfRelevantCategories: Boolean = relevantCategories.isEmpty() | |||
There was a problem hiding this comment.
c: 그냥 isEmptyRelevantCategories 는 어떠신지요? 그쪽이 더 읽기 매끄러운 느낌?!
| val ratingCount: Int?, | ||
| ) { | ||
|
|
||
| val isNothing: Boolean = id == null |
There was a problem hiding this comment.
a: isNothing 은 어떤 역할을 하나요? 변수명으로 봐서는 아무것도 아니다! 라는 느낌인데 🤔
There was a problem hiding this comment.
소설 모델 자체가 없다라는 뜻으로 만들어두었습니다.
변수 이름만 보기보단 객체 내부의 '객체 상태'값이니 객체의 이름과도 같이 유추해보면 좋을 것 같습니다.
사용부분에선 FeedModel.novel.isNothing으로 쓸 수 있긴한데 더욱 좋은 이름 있으면 추천좀용
There was a problem hiding this comment.
존재하지 않는다라는 느낌으로 가면 어떨까요
librarywon
approved these changes
Aug 18, 2024
- 카테고리 변경할 때 피드 호출하는 함수 아예 분리 - 모든 피드 조회전에 로딩 로직 추가
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌𝘐𝘴𝘴𝘶𝘦𝘴
📎𝘞𝘰𝘳𝘬 𝘋𝘦𝘴𝘤𝘳𝘪𝘱𝘵𝘪𝘰𝘯
📷𝘚𝘤𝘳𝘦𝘦𝘯𝘴𝘩𝘰𝘵
123123.webm
💬𝘛𝘰 𝘙𝘦𝘷𝘪𝘦𝘸𝘦𝘳𝘴