Fix "IntVal" considering boolean values as valid

The commit 54d17ab tried to fix the that "IntVal" would pass with values that are not considered as an integer, but it does not change Even thought the commit 54d17ab fixes part of the wrong behaviour it left out the filter for boolean values. Co-authored-by: Henrique Moody <[email protected]>
StarveTheEgo · Jun 28, 2018 · f5ca4a2 · f5ca4a2
1 parent 54d17ab
commit f5ca4a2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/library/Rules/IntVal.php b/library/Rules/IntVal.php
@@ -15,7 +15,7 @@ class IntVal extends AbstractRule
 {
     public function validate($input)
     {
-        if (is_float($input)) {
+        if (is_float($input) || is_bool($input)) {
             return false;
         }
 

diff --git a/tests/unit/Rules/IntValTest.php b/tests/unit/Rules/IntValTest.php
@@ -64,6 +64,8 @@ public function providerForNotInt()
             ['1.0'],
             [1.0],
             [' '],
+            [true],
+            [false],
             ['Foo'],
             ['1.44'],
             [1e-5],