Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🇮🇹] Italian language support #784

Open
TheMiguelBi opened this issue Apr 5, 2018 · 5 comments
Open

[🇮🇹] Italian language support #784

TheMiguelBi opened this issue Apr 5, 2018 · 5 comments
Assignees
Labels

Comments

@TheMiguelBi
Copy link
Contributor

TheMiguelBi commented Apr 5, 2018

I've created Italian language support for the web interface.
I think I did not understand how to update the program with the new language.
I added the string to webfile.h:
(But it is not enough).

   if (! SPIFFS.exists (String (F ("/ web / lang / en.lang.gz"))) || force) progmemToSpiffs (itlang, sizeof (itlang), String (F ("/ web / lang / en .lang.gz ")));

it.lang.gz

@tobozo tobozo added the translation Traduko label Apr 6, 2018
@tobozo
Copy link
Collaborator

tobozo commented Apr 6, 2018

Thank you for your contribution, I edited your comment for better code formatting and I'll let @spacehuhn answer to this part.

Is your knowledge of github good enough so you can submit a pull request with the two updated files (it.lang and it.lang.gz) or do you prefer to leave this task to the maintainers of this project ?

Submitting a pull request will make you appear in the contributors list so proper credit can be given.

@tobozo tobozo changed the title [IT] Italian language support [🇮🇹] Italian language support Apr 6, 2018
@spacehuhn
Copy link
Collaborator

Just add the it.lang file to the web interface folder.I will do the rest and it will included in the next release :)

@TheMiguelBi
Copy link
Contributor Author

Okay thank you!
I have combined something, I think.
#788 and #789

@tobozo
Copy link
Collaborator

tobozo commented Apr 6, 2018

Grazie mille :-)

We'll only merge the #788 for the meantime, I'm doing Travis CI tests and it'll eventually get processed automatically.

Please don't close the pull request with the .gz file yet as I have no idea when Travis CI will be able to handle that ^^

@TheMiguelBi
Copy link
Contributor Author

Perfect thanks!
Now I can have the web interface in Italian!

(I'm noticing any missing capital letters... I will fix the it.lang file soon.
Furthermore, the fifth "information" page has not yet been translated.).

@stale stale bot added the wontfix label Jun 16, 2020
@spacehuhn spacehuhn removed the wontfix label Jun 16, 2020
@SpacehuhnTech SpacehuhnTech deleted a comment from stale bot Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants