-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Inconsistent JSON Formatting #3719
Comments
Just a further comment on this, where the JSON had been unescaped in the templates - it worked fine in theme Customizer but not on the front-end when putting the theme live. |
This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. P.S. You can learn more about why we stale issues here. |
Bump |
This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. P.S. You can learn more about why we stale issues here. |
This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. P.S. You can learn more about why we stale issues here. |
still relevant |
Please confirm that you have:
In which of these areas are you experiencing a problem?
Theme
Expected behavior
The format of .json templates to be consistent throughout systems.
Actual behavior
Verbose output
Reproduction steps
Download the Theme from the Shopify Admin (using the "download theme file" button).
Drop the contents over your locally setup Theme and See the File differences.
Setup a Theme using the GitHub Integration and customize a these templates using the "Customize" action.
Using the CLI run "shopify theme dev --theme-editor-sync" against that Repository and branch, you'll get notified that files between your local copy and the theme dev copy are different, choose to keep local. The templates will now get downloaded regardless, but without the JSON being escape.
In both scenarios you're left with changes to your .json templates, whereas ideally it should be consistent between all three systems.
Operating System
Windows 11
Shopify CLI version (check your project's
package.json
if you're not sure)3.58.2
Shell
Git Bash
Node version (run
node -v
if you're not sure)18.12.1
What language and version are you using in your application?
N/A
The text was updated successfully, but these errors were encountered: