Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Characters are Broken on Git Build (except for Spirit for some reason) #1365

Closed
crowplexus opened this issue Nov 25, 2021 · 6 comments
Closed
Labels
bug Something isn't working

Comments

@crowplexus
Copy link
Contributor

crowplexus commented Nov 25, 2021

Describe your bug here.

aside from the Story Mode menu, Characters are broken, they don't have any animations and if you try to load any song, it will crash

on Character Editor (sorry if I took ages to check every single animation)

2021-11-25.15-58-03.mp4

in Game

2021-11-25.16-01-46.mp4

Command Prompt/Terminal logs (if existing)

source/LoadingState.hx:162: Setting asset folder to shared
source/LoadingState.hx:162: Setting asset folder to shared
source/FreeplayState.hx:292: thorns-hard
source/FreeplayState.hx:299: CURRENT WEEK: week6
source/LoadingState.hx:162: Setting asset folder to week6
source/Conductor.hx:59: new BPM map BUDDY []
source/PlayState.hx:318: stage is: null

Are you modding a build from source or with Lua?

Source

What is your build target?

Linux

Did you edit anything in this build? If so, mention or summarize your changes.

No, I didn't edit anything

@crowplexus crowplexus added the bug Something isn't working label Nov 25, 2021
@CowSoftware
Copy link

CowSoftware commented Nov 25, 2021

I did mention this (#1353) it seems like the whole "softcode atlas package" breaks the whole game, so all we can do is wait for this pull request (#1360) to merge into the base engine GitHub.

@crowplexus
Copy link
Contributor Author

I did mention this (#1353) it seems like the whole "softcode atlas package" breaks the whole game, so all we can do is wait for this pull request (#1360 (comment)) to merge into the base engine GitHub.

funny enough, everything works on Web, from the previous Bug report I made (#1364), to the characters and the game itself

Characters.mp4
Graphic.Settings.mp4

@CowSoftware
Copy link

I did mention this (#1353) it seems like the whole "softcode atlas package" breaks the whole game, so all we can do is wait for this pull request (#1360 (comment)) to merge into the base engine GitHub.

funny enough, everything works on Web, from the previous Bug report I made (#1364), to the characters and the game itself

Characters.mp4
Graphic.Settings.mp4

Maybe because the web version doesn't use the package? I'm not too sure.

@haya3218
Copy link
Contributor

Pull request #1360 fixes this. Turns out it was some code failing or just not working and loading packer atlas for the other characters (hence why spirit works) instead of sparrow.

@ShadowMario u stoopid

@SrtHero278
Copy link

The reason only spirit works is because the game is only looking for txt files. Not both xml files and txt files.

@ShadowMario
Copy link
Owner

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants