Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: SciML/Sundials.jl
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v4.23.1
Choose a base ref
...
head repository: SciML/Sundials.jl
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v4.23.2
Choose a head ref
  • 8 commits
  • 8 files changed
  • 6 contributors

Commits on Sep 23, 2023

  1. Fix handling of small timesteps

    Sundials solver is allowed to warn and continue if it returns a timestep
    with no change in t.
    If the solver doesn't recover, it will fail with eg SciMLBase.ReturnCode.MaxIters
    
    Reverts PR #416, fixes
    #420
    
    For CVode and ARKode, it looks like this is intended behaviour: the
    Sundial solver emits a warning message, with an API call
        CVodeSetMaxHnilWarns
        ARKStepSetMaxHnilWarns
    to set the maximum number of warning messages printed, which is exposed
    to Julia as
        max_hnil_warns
    see Sundials driver code https://github.com/LLNL/sundials/blob/e8a3e67e3883bc316c48bc534ee08319a5e8c620/src/cvode/cvode.c#L1339-L1347
    
    For IDA, there is no API like this so it's not so clear what should happen,
    however the behaviour prior to #416 (restored by this PR)
    for the f_noconverge test added in test/common_interface/ida.jl is to return
      SciMLBase.ReturnCode.MaxIters
    which seems reasonable?
    
    (NB: @oscardssmith I can't reproduce the issue implied by the title of
    #416 so perhaps what is missing here
    is the original failure case that demonstrates the issue?
    The call to solve in the f_noconverge test test/common_interface/ida.jl, returns SciMLBase.ReturnCode.MaxIters,
    it doesn't return with no error?
    
    Also SciML/SciMLBase.jl#458 shows IDA printing
      [IDAS ERROR]  IDASolve
        At t = 0 and h = 1.49012e-18, the error test failed repeatedly or with |h| = hmin.
    which suggests that IDA did flag an error in that case ?
    )
    sjdaines committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    89a643d View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2023

  1. Configuration menu
    Copy the full SHA
    849ef80 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2024

  1. Bump actions/cache from 3 to 4

    Bumps [actions/cache](https://github.com/actions/cache) from 3 to 4.
    - [Release notes](https://github.com/actions/cache/releases)
    - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
    - [Commits](actions/cache@v3...v4)
    
    ---
    updated-dependencies:
    - dependency-name: actions/cache
      dependency-type: direct:production
      update-type: version-update:semver-major
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] authored and ChrisRackauckas committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    270df7f View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. fix depwarns

    ChrisRackauckas committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    8b91268 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2024

  1. use vcat rather than append! to combine d_discontinuities and `…

    …tstops`
    
    this version works when tstops is a scalar.
    oscardssmith authored and ChrisRackauckas committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    ec26e2e View commit details
    Browse the repository at this point in the history
  2. add test

    oscardssmith authored and ChrisRackauckas committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    c717d8b View commit details
    Browse the repository at this point in the history
  3. Memory-safety and allocations fixes for Handle{T}

    Addresses #435 and
    also fixes a potential problem with memory safety:
    
    1) Allocations in convert(Ptr{T}, Handle{T})
       Fix is as suggested in #435
       (Handle is now a mutable struct with a ptr field)
    
    2) Memory safety robustness fix
       Remove convert and use paired Base.cconvert / Base.unsafe_convert to get the ptr field from
       a Handle object h, so that the h is preserved from GC across the ccall
       This fix is analogous to that for the NVector wrapper in PR #380
       (NB: there is no actual problem at least when Sundials is used with the SciML interface,
       as the Handle{CVODEMem} and similar objects are held by a persistent solver data structure, but this
       change should reduce the risk of something going wrong in the future, or for eg test harnesses that don't use
       the SciML interface)
    sjdaines authored and ChrisRackauckas committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    ab0e08f View commit details
    Browse the repository at this point in the history
  4. Update Project.toml

    ChrisRackauckas authored Jan 27, 2024
    Configuration menu
    Copy the full SHA
    ce4753f View commit details
    Browse the repository at this point in the history
Loading