Historic IP addresses included in invites are rendered invalid by omitting the last digit of the port

[rednil]

Using the new certificate format, IP addresses included in an invite are rendered invalid by omitting the last digit of the port.

Reproduce

Create an invite that includes the complete IP address history. Add this friend in another instance or use a Base64 decoder to look into the invite. Observe that the last digit of the port is missing, i.e. 3ipv6://[2103:c7:9720:d377:165d:efb4:d504:d25e]:420 when port "4200" was used.

Workaround

Use the "old certificate format". In this case, ports are properly included

[csoler]

I cannot reproduce it. Can it be that you are missing the = at the end?

[rednil]

@csoler Thank you for looking into this. By the way, thank you for your hard work on this excellent project. Please find below two invites generated with 0.6.7 on Ubuntu 22.04, first in the "new" format (showing the bug), then in the "old" format (correct port numbers). I also attached screenshots of the IP addresses of the exporting node, then after importing the invite (generated with the the new format) into another node (also 0.6.7 on Ubuntu 22.04). I hope that helps to reproduce the issue. Best regards

New Format

ABCL3ecZDHNZ0z7r1v1tvu18AxTCKsSx8Phq8u67TYXmB9qk1D/l3gEJQ2hyaXNjaGFuAhhpcHY0Oi8vMTkyLjE2OC4xNDQuMTo0
MjACNGlwdjY6Ly9bMmEwMjo2MWUwOjIwYTI6N2Y1MTo3NGU1OmM2ZjM6OTIxNjpiZmY1XTo0MjACFWlwdjQ6Ly8xNzIuMTcuMC4x
OjQyMAIVaXB2NDovLzE3Mi4xOC4wLjE6NDIwAjRpcHY2Oi8vWzJhMDI6NjFlMDoyMGEyOjdmNTE6Y2Q0NjpmYWNlOjczMzU6ODk4
NV06NDIwAhdpcHY0Oi8vMTkyLjE2OC4xLjQyOjQyMAIVaXB2NDovLzE3Mi4xOS4wLjE6NDIwAhlpcHY0Oi8vMTg1LjE5OS44My4y
MzY6NDIwBANTcZQ=

Old Format

CQEGAcGaxsBNBFXda74BCACwg6yWrFGX2YYFM3Ozf8OKN4c5z9A09YM1fD6HM+Xx
XKDg3bEgrsoJ9N8V0PQokBZmhMV2YQ1DMXaFzAXAmpUE/ZLkD2wM6LZa5EpskgeP
SclgrNm8CsqfAn6Ej6p3o7+y+rnjHZUBj5rpwu2ZuRBEX3Et1CIbLq1qgrzkmePY
Nfa5b+n8cXj0zoeI2zBALPCbLzEHregEwUAzxq8LBCOFbNvx3VSugujfdiPnVFJ+
Y0PM0IiqHPv9yAySHzy3HfOAyrB4amWun1o7bs6qC38TpLW4IOjb23kpkC35/2ZQ
rmCsdqkvnwa3rOVfw4p2FkGug2jX6mIThUnuSNXUdUV7ABEBAAHNJkNocmlzY2hh
biAoR2VuZXJhdGVkIGJ5IFJldHJvU2hhcmUpIDw+wsBfBBMBAgATBQJV3Wu+CRDm
B9qk1D/l3gIZAQAAo+UH/1L5DUYhvmgdrSyl2u3tbX/qudv/iRFCTXXATI2FPEul
H36ohGv/nNf5VbI/SCE4pbUhL8IN44d+lVjMnRpeBVIrMtZGEc9oz9iuIspa+/ya
AMj9BHiRT0shS5E9+nIzludmeTGwAegsgoY3zWqZ03T39WmYt+NquGSJaP9fKu59
3IPIx6DhMZBX4XscApvQOTo3kKbQr4FhTHq++c8sqw3g4dCqFhDCfxULiiHqg+/x
zftxg0L/NTOvPXnwxgDE+NpDPnMrsVH+OTzyFbrQvy1hD+sYbA4+OQYL6cgh7EDL
K4oqzZn9EDUi2XtVIdy5JbQd1r9yqPr3XQqEVrU5YEUCBrnHU+wQaAMGwKgBKhBo
BgtNeSBjb21wdXRlcgUQi93nGQxzWdM+69b9bb7tfAoWaXB2NDovLzE3Mi4xNy4w
LjE6NDIwMAoWaXB2NDovLzE3Mi4xOC4wLjE6NDIwMAoWaXB2NDovLzE3Mi4xOS4w
LjE6NDIwMAoaaXB2NDovLzE4NS4xOTkuODMuMjM2OjQyMDAKGGlwdjQ6Ly8xOTIu
MTY4LjEuNDI6NDIwMAoZaXB2NDovLzE5Mi4xNjguMTQ0LjE6NDIwMAo1aXB2Njov
L1syYTAyOjYxZTA6MjBhMjo3ZjUxOjc0ZTU6YzZmMzo5MjE2OmJmZjVdOjQyMDAK
NWlwdjY6Ly9bMmEwMjo2MWUwOjIwYTI6N2Y1MTpjZDQ2OmZhY2U6NzMzNTo4OTg1
XTo0MjAwBwPFSYw=

[csoler]

Fixed in PR 138
Thx a lot for finding/reporting this.