Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redis-benchmark with --cluster #642

Open
phanirithvij opened this issue Aug 17, 2023 · 0 comments
Open

redis-benchmark with --cluster #642

phanirithvij opened this issue Aug 17, 2023 · 0 comments

Comments

@phanirithvij
Copy link

phanirithvij commented Aug 17, 2023

redis-benchmark with --cluster option while using redisraft with the example from in the readme (1 leader and two members) fails because there is a check that is requiring 2 or more leaders in redis-benchmark code

https://github.com/redis/redis/blob/44cc0fcb9d8bfa194f65f306bce7f91d17ada2ed/src/redis-benchmark.c#L1808-L1812

Changing it from <= 1 to < 1 and recompiling works.

I used the memtier_benchmark as it is what is being used to benchmark this project, it works fine with --cluster option.

https://github.com/RedisLabs/redisraft/blob/ade4aa8e6aa5c3b21678a1998309825f06567d4f/benchmark/benchmark.json#L4C20-L4C20

(Wasn't sure where to open the issue, thought here would be better as I believe the discussion belongs here? Idk. Also I have never used redis cluster before, only experimenting with redisraft for the first time and thus I am not sure why the 2 or more master restriction exists)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant