Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rcgen to 0.13.1 #380

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Update rcgen to 0.13.1 #380

merged 1 commit into from
Apr 22, 2024

Conversation

patowen
Copy link
Collaborator

@patowen patowen commented Apr 21, 2024

@patowen patowen requested a review from Ralith April 21, 2024 16:07
@patowen
Copy link
Collaborator Author

patowen commented Apr 21, 2024

This PR "works", but it results in the installation of two versions of ring, one as a dependency of rcgen, and the other as a dependency of quinn-proto, so it's possible we might want to wait on this one as well. That being said, it doesn't seem to cause any actual compatibility issues, so this PR may be in a good state to merge anyway.

Ralith
Ralith approved these changes Apr 22, 2024
View reviewed changes
Copy link
Owner

@Ralith Ralith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New Quinn release is coming Soon™, so probably fine to get this out of the way.

@Ralith Ralith merged commit fd69b55 into Ralith:master Apr 22, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ralith Ralith Ralith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patowen @Ralith