Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop dependabot from updating packages that likely cannot be updated #359

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

patowen
Copy link
Collaborator

@patowen patowen commented Feb 24, 2024

This PR stops dependabot from checking for updates of raw-window-handle, rustls, and rustls-pemfile because updates to these crates have to be done in tandem with upgrades to other crates (namely ash-window and quinn).

@patowen
Copy link
Collaborator Author

patowen commented Feb 24, 2024

@Ralith, I don't know if there's a good way to ensure that this PR will work as intended. I have a few concerns, and the answer might simply be to merge this PR and see what happens, but I'd be interested in your thoughts here:

  • If one of these crates has a CVE-related security update, will Dependabot let us know? Since cargo.lock isn't checked in, documentation suggests that this isn't the case, but I decided to try to at least leave the option open by only blocking major version updates.
  • Is Dependabot aware that the format 0.major.minor is often used, or will it treat 0.11 to 0.12 as a minor version upgrade?

Also, how much should we worry about security (at least with automatic detection)? If one of our dependencies misuses unsafe in a way that potentially allows save files or netcode to be exploited, that could make Hypermine dangerous when sharing save files or playing on whatever the equivalent of public servers are for niche things like Hypermine. However, at the same time, the attack surface seems pretty low, and a vulnerability that would make Hypermine dangerous is maybe something we would hear about anyway regardless of whether Dependabot would let us know.

If we don't need to worry about security here, it might be nicer just to ignore these dependencies instead of filtering to major versions, since minor and patch versions are usually automatic anyway.

@Ralith
Copy link
Owner

Ralith commented Feb 25, 2024

Per docs, I don't think minor version updates exist unless we commit Cargo.lock, and if they did they'd probably be spammier than we have the resources to support.

@patowen
Copy link
Collaborator Author

patowen commented Feb 25, 2024

That's a fair point. I'll go ahead and just include a list of dependencies to ignore instead of trying to do anything fancier.

@Ralith Ralith merged commit 49b13f7 into Ralith:master Mar 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants