Tests revealed a couple of bugs in the codebase. #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One related to the simplification of the Job API. It is now raising JobTimeoutError instead of TimeoutError and we forgot to update a reference. It also evindentiates an inconsistency in the way we treat exceptions. The other was related to a new update in the IBMQuantumExperience library. Now some server errors raise an ApiError that was not captured before.
delapuente
requested review from
ajavadia,
diego-plan9 and
ewinston
as code owners
delapuente
commented
Aug 15, 2018
qiskit/backends/ibmq/ibmqjob.py
Outdated
| @@ -184,7 +184,7 @@ def result(self, timeout=None, wait=5): | |||
| self._wait_for_submission() | |||
| try: | |||
| this_result = self._wait_for_job(timeout=timeout, wait=wait) | |||
| except TimeoutError as err: | |||
| except JobTimeoutError as err: | |||
| # A timeout error retrieving the results does not imply the job | |||
| # is failing. The job can be still running. This is why we are not | |||
There was a problem hiding this comment.
We are explaining that "we throw if an error prevents Qiskit from knowing the exact state of a Job". Here, we do the contrary. I vote for changing this behaviour to make it consistent and change the tests accordingly.
atilag
reviewed
Aug 15, 2018
test/python/test_ibmqjob_states.py
Outdated
| result = job.result(timeout=0.2) | ||
| # TODO: This is inconsistent, the timeout prevents Qiskit from knowing | ||
| # the exact state of the job so it should raise. | ||
| self.assertRaises(QISKitError, result.get_data) |
There was a problem hiding this comment.
It should be throwing JobTimeoutError here, right?
There was a problem hiding this comment.
It should, that way, we make it consistent again. But it's not because the error is not in the Job but in the Result object.
atilag
approved these changes
Aug 16, 2018
lia-approves
pushed a commit
to edasgupta/qiskit-terra
that referenced
this pull request
Jul 30, 2019
…ling Tests revealed a couple of bugs in the codebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #780
One related to the simplification of the Job API. It is now raising JobTimeoutError instead of TimeoutError and we forgot to update a reference. It also evidentiates an inconsistency in the way we treat exceptions.
The other was related to a new update in the IBMQuantumExperience library. Now some server errors raise an ApiError that was not captured before.