-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unnecessary serialisation of PassManager
in serial contexts (backport #12410)
#12500
Conversation
…2410) * Fix unnecessary serialisation of `PassManager` in serial contexts This exposes the interal decision in `parallel_map` of whether to actually run in serial or not. If not, there's no need for `PassManager` to side-car its `dill` serialisation onto the side of the IPC (we use `dill` because we need to pickle lambdas), which can be an unfortunately huge cost for certain IBM pulse-enabled backends. * Remove new function from public API This makes the patch series safe for backport to 1.1. (cherry picked from commit b12e9ec) # Conflicts: # qiskit/utils/__init__.py # qiskit/utils/parallel.py
Cherry-pick of b12e9ec has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 9419158300Details
💛 - Coveralls |
Summary
This exposes the interal decision in
parallel_map
of whether to actually run in serial or not. If not, there's no need forPassManager
to side-car itsdill
serialisation onto the side of the IPC (we usedill
because we need to pickle lambdas), which can be an unfortunately huge cost for certain IBM pulse-enabled backends.Details and comments
@sbrandhsn: as the release manager for 1.1.0, it's up to you whether you want to accept this PR in this form for 1.1.0, or defer to 1.1.1 (you can tag the milestone appropriately). I could also suppress exporting
should_run_in_parallel
into the public namespace if you're not on board with a new public feature this late into the release cycle.This is an automatic backport of pull request #12410 done by Mergify.