Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated operators tutorials #11084

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Remove deprecated operators tutorials #11084

merged 1 commit into from
Oct 23, 2023

Conversation

ElePT
Copy link
Contributor

@ElePT ElePT commented Oct 23, 2023

Summary

These tutorials use code from several deprecated modules, including opflow and algorithms, which will be removed in 1.0. This PR is a pre-requisite for addressing #10991, as once the deprecated code starts being removed, the tutorials would break.

Details and comments

@ElePT ElePT requested a review from a team as a code owner October 23, 2023 11:56
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

jakelishman
jakelishman approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks right to me, thanks.

@jakelishman jakelishman added documentation Something is not clear or an error documentation Changelog: None Do not include in changelog labels Oct 23, 2023
@jakelishman jakelishman added this to the 1.0.0 milestone Oct 23, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6612858380

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 18 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.02%) to 86.88%
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/expr.rs 1 93.76%
crates/qasm2/src/lex.rs 5 91.16%
crates/qasm2/src/parse.rs 12 96.67%
Totals Coverage Status
Change from base Build 6612358367: -0.02%
Covered Lines: 73834
Relevant Lines: 84984
💛 - Coveralls

@jakelishman jakelishman added this pull request to the merge queue Oct 23, 2023
Eric-Arellano
Eric-Arellano approved these changes Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Btw these are not migrated to https://github.com/Qiskit/documentation either.

Merged via the queue into Qiskit:main with commit fe3bffb Oct 23, 2023
14 checks passed
@kdk kdk modified the milestones: 1.0.0, 1.0.0pre1 Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakelishman jakelishman jakelishman approved these changes

@Eric-Arellano Eric-Arellano Eric-Arellano approved these changes

Assignees
No one assigned
Labels
Changelog: None Do not include in changelog documentation Something is not clear or an error documentation
Projects
None yet
Milestone
1.0.0b1
Development

Successfully merging this pull request may close these issues.
6 participants
@ElePT @qiskit-bot @coveralls @jakelishman @Eric-Arellano @kdk