Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo/grammar fixes on transpiler docs #11070

Merged
merged 7 commits into from
Oct 21, 2023
Merged

Conversation

ElePT
Copy link
Contributor

@ElePT ElePT commented Oct 20, 2023

Summary

A compilation of fixes for minor typos/mis-formatted code blocks plus some restructuring of the sentences in the scheduling section to (hopefully) improve readability.

Details and comments

@ElePT ElePT added the documentation Something is not clear or an error documentation label Oct 20, 2023
@ElePT ElePT requested a review from a team as a code owner October 20, 2023 15:45
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6589890144

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 86.909%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 5 91.92%
Totals Coverage Status
Change from base Build 6588513305: 0.02%
Covered Lines: 73877
Relevant Lines: 85005

💛 - Coveralls

mtreinish
mtreinish previously approved these changes Oct 20, 2023
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing all of this. I left an inline comment on some refs we can use but it's not critical.

qiskit/transpiler/__init__.py Outdated Show resolved Hide resolved
qiskit/transpiler/__init__.py Outdated Show resolved Hide resolved
qiskit/transpiler/__init__.py Outdated Show resolved Hide resolved
qiskit/transpiler/__init__.py Outdated Show resolved Hide resolved
qiskit/transpiler/__init__.py Outdated Show resolved Hide resolved
qiskit/transpiler/__init__.py Outdated Show resolved Hide resolved
@mtreinish mtreinish added the stable backport potential The bug might be minimal and/or import enough to be port to stable label Oct 21, 2023
@mtreinish mtreinish added this pull request to the merge queue Oct 21, 2023
Merged via the queue into Qiskit:main with commit 79812b5 Oct 21, 2023
14 checks passed
mergify bot pushed a commit that referenced this pull request Oct 21, 2023
* Fix typos

* Update qiskit/transpiler/__init__.py

Co-authored-by: Matthew Treinish <[email protected]>

* Update qiskit/transpiler/__init__.py

Co-authored-by: Matthew Treinish <[email protected]>

* Update qiskit/transpiler/__init__.py

Co-authored-by: Matthew Treinish <[email protected]>

* Update qiskit/transpiler/__init__.py

Co-authored-by: Matthew Treinish <[email protected]>

* Update qiskit/transpiler/__init__.py

Co-authored-by: Matthew Treinish <[email protected]>

* Update qiskit/transpiler/__init__.py

Co-authored-by: Matthew Treinish <[email protected]>

---------

Co-authored-by: Matthew Treinish <[email protected]>
(cherry picked from commit 79812b5)
github-merge-queue bot pushed a commit that referenced this pull request Oct 21, 2023
* Fix typos

* Update qiskit/transpiler/__init__.py

Co-authored-by: Matthew Treinish <[email protected]>

* Update qiskit/transpiler/__init__.py

Co-authored-by: Matthew Treinish <[email protected]>

* Update qiskit/transpiler/__init__.py

Co-authored-by: Matthew Treinish <[email protected]>

* Update qiskit/transpiler/__init__.py

Co-authored-by: Matthew Treinish <[email protected]>

* Update qiskit/transpiler/__init__.py

Co-authored-by: Matthew Treinish <[email protected]>

* Update qiskit/transpiler/__init__.py

Co-authored-by: Matthew Treinish <[email protected]>

---------

Co-authored-by: Matthew Treinish <[email protected]>
(cherry picked from commit 79812b5)

Co-authored-by: Elena Peña Tapia <[email protected]>
mtreinish pushed a commit to mtreinish/qiskit-core that referenced this pull request Oct 23, 2023
* Fix typos

* Update qiskit/transpiler/__init__.py

Co-authored-by: Matthew Treinish <[email protected]>

* Update qiskit/transpiler/__init__.py

Co-authored-by: Matthew Treinish <[email protected]>

* Update qiskit/transpiler/__init__.py

Co-authored-by: Matthew Treinish <[email protected]>

* Update qiskit/transpiler/__init__.py

Co-authored-by: Matthew Treinish <[email protected]>

* Update qiskit/transpiler/__init__.py

Co-authored-by: Matthew Treinish <[email protected]>

* Update qiskit/transpiler/__init__.py

Co-authored-by: Matthew Treinish <[email protected]>

---------

Co-authored-by: Matthew Treinish <[email protected]>
(cherry picked from commit 79812b5)

Co-authored-by: Elena Peña Tapia <[email protected]>
(cherry picked from commit 4b0d30e)
mtreinish pushed a commit to mtreinish/qiskit-core that referenced this pull request Oct 23, 2023
* Fix typos

* Update qiskit/transpiler/__init__.py

Co-authored-by: Matthew Treinish <[email protected]>

* Update qiskit/transpiler/__init__.py

Co-authored-by: Matthew Treinish <[email protected]>

* Update qiskit/transpiler/__init__.py

Co-authored-by: Matthew Treinish <[email protected]>

* Update qiskit/transpiler/__init__.py

Co-authored-by: Matthew Treinish <[email protected]>

* Update qiskit/transpiler/__init__.py

Co-authored-by: Matthew Treinish <[email protected]>

* Update qiskit/transpiler/__init__.py

Co-authored-by: Matthew Treinish <[email protected]>

---------

Co-authored-by: Matthew Treinish <[email protected]>
(cherry picked from commit 79812b5)

Co-authored-by: Elena Peña Tapia <[email protected]>
(cherry picked from commit 4b0d30e)
github-merge-queue bot pushed a commit that referenced this pull request Oct 25, 2023
* Fix typos

* Update qiskit/transpiler/__init__.py

Co-authored-by: Matthew Treinish <[email protected]>

* Update qiskit/transpiler/__init__.py

Co-authored-by: Matthew Treinish <[email protected]>

* Update qiskit/transpiler/__init__.py

Co-authored-by: Matthew Treinish <[email protected]>

* Update qiskit/transpiler/__init__.py

Co-authored-by: Matthew Treinish <[email protected]>

* Update qiskit/transpiler/__init__.py

Co-authored-by: Matthew Treinish <[email protected]>

* Update qiskit/transpiler/__init__.py

Co-authored-by: Matthew Treinish <[email protected]>

---------

Co-authored-by: Matthew Treinish <[email protected]>
(cherry picked from commit 79812b5)

Co-authored-by: Elena Peña Tapia <[email protected]>
(cherry picked from commit 4b0d30e)

Co-authored-by: Elena Peña Tapia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Something is not clear or an error documentation stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants