-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typo/grammar fixes on transpiler docs #11070
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 6589890144
💛 - Coveralls |
mtreinish
previously approved these changes
Oct 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for fixing all of this. I left an inline comment on some refs we can use but it's not critical.
Co-authored-by: Matthew Treinish <[email protected]>
Co-authored-by: Matthew Treinish <[email protected]>
Co-authored-by: Matthew Treinish <[email protected]>
Co-authored-by: Matthew Treinish <[email protected]>
Co-authored-by: Matthew Treinish <[email protected]>
Co-authored-by: Matthew Treinish <[email protected]>
mtreinish
approved these changes
Oct 21, 2023
mtreinish
added
the
stable backport potential
The bug might be minimal and/or import enough to be port to stable
label
Oct 21, 2023
mergify bot
pushed a commit
that referenced
this pull request
Oct 21, 2023
* Fix typos * Update qiskit/transpiler/__init__.py Co-authored-by: Matthew Treinish <[email protected]> * Update qiskit/transpiler/__init__.py Co-authored-by: Matthew Treinish <[email protected]> * Update qiskit/transpiler/__init__.py Co-authored-by: Matthew Treinish <[email protected]> * Update qiskit/transpiler/__init__.py Co-authored-by: Matthew Treinish <[email protected]> * Update qiskit/transpiler/__init__.py Co-authored-by: Matthew Treinish <[email protected]> * Update qiskit/transpiler/__init__.py Co-authored-by: Matthew Treinish <[email protected]> --------- Co-authored-by: Matthew Treinish <[email protected]> (cherry picked from commit 79812b5)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 21, 2023
* Fix typos * Update qiskit/transpiler/__init__.py Co-authored-by: Matthew Treinish <[email protected]> * Update qiskit/transpiler/__init__.py Co-authored-by: Matthew Treinish <[email protected]> * Update qiskit/transpiler/__init__.py Co-authored-by: Matthew Treinish <[email protected]> * Update qiskit/transpiler/__init__.py Co-authored-by: Matthew Treinish <[email protected]> * Update qiskit/transpiler/__init__.py Co-authored-by: Matthew Treinish <[email protected]> * Update qiskit/transpiler/__init__.py Co-authored-by: Matthew Treinish <[email protected]> --------- Co-authored-by: Matthew Treinish <[email protected]> (cherry picked from commit 79812b5) Co-authored-by: Elena Peña Tapia <[email protected]>
mtreinish
pushed a commit
to mtreinish/qiskit-core
that referenced
this pull request
Oct 23, 2023
* Fix typos * Update qiskit/transpiler/__init__.py Co-authored-by: Matthew Treinish <[email protected]> * Update qiskit/transpiler/__init__.py Co-authored-by: Matthew Treinish <[email protected]> * Update qiskit/transpiler/__init__.py Co-authored-by: Matthew Treinish <[email protected]> * Update qiskit/transpiler/__init__.py Co-authored-by: Matthew Treinish <[email protected]> * Update qiskit/transpiler/__init__.py Co-authored-by: Matthew Treinish <[email protected]> * Update qiskit/transpiler/__init__.py Co-authored-by: Matthew Treinish <[email protected]> --------- Co-authored-by: Matthew Treinish <[email protected]> (cherry picked from commit 79812b5) Co-authored-by: Elena Peña Tapia <[email protected]> (cherry picked from commit 4b0d30e)
mtreinish
pushed a commit
to mtreinish/qiskit-core
that referenced
this pull request
Oct 23, 2023
* Fix typos * Update qiskit/transpiler/__init__.py Co-authored-by: Matthew Treinish <[email protected]> * Update qiskit/transpiler/__init__.py Co-authored-by: Matthew Treinish <[email protected]> * Update qiskit/transpiler/__init__.py Co-authored-by: Matthew Treinish <[email protected]> * Update qiskit/transpiler/__init__.py Co-authored-by: Matthew Treinish <[email protected]> * Update qiskit/transpiler/__init__.py Co-authored-by: Matthew Treinish <[email protected]> * Update qiskit/transpiler/__init__.py Co-authored-by: Matthew Treinish <[email protected]> --------- Co-authored-by: Matthew Treinish <[email protected]> (cherry picked from commit 79812b5) Co-authored-by: Elena Peña Tapia <[email protected]> (cherry picked from commit 4b0d30e)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 25, 2023
* Fix typos * Update qiskit/transpiler/__init__.py Co-authored-by: Matthew Treinish <[email protected]> * Update qiskit/transpiler/__init__.py Co-authored-by: Matthew Treinish <[email protected]> * Update qiskit/transpiler/__init__.py Co-authored-by: Matthew Treinish <[email protected]> * Update qiskit/transpiler/__init__.py Co-authored-by: Matthew Treinish <[email protected]> * Update qiskit/transpiler/__init__.py Co-authored-by: Matthew Treinish <[email protected]> * Update qiskit/transpiler/__init__.py Co-authored-by: Matthew Treinish <[email protected]> --------- Co-authored-by: Matthew Treinish <[email protected]> (cherry picked from commit 79812b5) Co-authored-by: Elena Peña Tapia <[email protected]> (cherry picked from commit 4b0d30e) Co-authored-by: Elena Peña Tapia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Something is not clear or an error documentation
stable backport potential
The bug might be minimal and/or import enough to be port to stable
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A compilation of fixes for minor typos/mis-formatted code blocks plus some restructuring of the sentences in the scheduling section to (hopefully) improve readability.
Details and comments