Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove quantum_info deprecated code in 0.22 #10861

Merged
merged 3 commits into from
Sep 20, 2023
Merged

Conversation

doublehoon
Copy link
Contributor

@doublehoon doublehoon commented Sep 19, 2023

Summary

Remove deprecated code and tests in 0.22

Details and comments

@doublehoon doublehoon requested review from ikkoham and a team as code owners September 19, 2023 04:15
@qiskit-bot qiskit-bot added the Community PR PRs from contributors that are not 'members' of the Qiskit repo label Sep 19, 2023
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core
  • @ikkoham

@coveralls
Copy link

coveralls commented Sep 19, 2023

Pull Request Test Coverage Report for Build 6233330075

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 15 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.01%) to 87.265%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 3 91.41%
crates/qasm2/src/parse.rs 12 97.13%
Totals Coverage Status
Change from base Build 6209701566: -0.01%
Covered Lines: 74160
Relevant Lines: 84983

💛 - Coveralls

@1ucian0 1ucian0 added the Changelog: Removal Include in the Removed section of the changelog label Sep 19, 2023
@1ucian0 1ucian0 changed the title Remove deprecated code in 0.22 Remove quantum_info deprecated code in 0.22 Sep 19, 2023
@1ucian0 1ucian0 self-assigned this Sep 19, 2023
Copy link
Member

@1ucian0 1ucian0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work again! Let's merge it!

@1ucian0 1ucian0 added this to the 0.45.0 milestone Sep 19, 2023
@1ucian0 1ucian0 added this pull request to the merge queue Sep 19, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 19, 2023
@1ucian0 1ucian0 added this pull request to the merge queue Sep 20, 2023
Merged via the queue into Qiskit:main with commit d559659 Sep 20, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Removal Include in the Removed section of the changelog Community PR PRs from contributors that are not 'members' of the Qiskit repo
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Remove code deprecated in 0.22 (released on October 13, 2022) [quantum_info]
4 participants