Deprecate bind_parameters in favor of assign_parameters
#10792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElePT
requested review from
ikkoham,
t-imamichi,
a team,
nonhermitian,
alexanderivrii,
ShellyGarion and
woodsp-ibm
as code owners
|
One or more of the the following people are requested to review this:
|
jakelishman
reviewed
Sep 7, 2023
releasenotes/notes/deprecate-bind-parameters-283c94069e8a9142.yaml
Outdated
Show resolved
Hide resolved
jakelishman
reviewed
Sep 7, 2023
ElePT
added
the
Changelog: Deprecation
jakelishman
approved these changes
Sep 12, 2023
There was a problem hiding this comment.
This looks good to me now, thanks Elena. I'm strongly expecting that we'll get some complaints about people wishing we'd use one name over the other, but since assign_parameters is the superset of functionality of bind_parameters, the decision was already made for us.
(And personally I prefer assign anyway haha)
Comment on lines
+503
to
+505
| # TODO: delete once bind_parameters is removed from the codebase | ||
| warnings.filterwarnings("ignore", category=DeprecationWarning) | ||
|
|
There was a problem hiding this comment.
This appears to need the manual override because of the getattr call changing the stack depth of the deprecated access, right? We could rewrite the test to avoid needing this, but it's probably cleanest just to leave it the way you have.
garrison
added a commit
to Qiskit/qiskit-addon-cutting
that referenced
this pull request
Sep 12, 2023
... as `bind_parameters` has been deprecated (Qiskit/qiskit#10792)
garrison
added a commit
to Qiskit/qiskit-addon-cutting
that referenced
this pull request
Sep 13, 2023
... as `bind_parameters` has been deprecated (Qiskit/qiskit#10792)
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7057 (unless there is any strong argument to keep both methods in Qiskit 1.0).
Fix #8958
Details and comments
bind_parameterswas only used in a couple of places internally. I went through these to make sure that we would not need any additional checks for the assigned values (asbind_parameterswould fail forParameterExpressions):Sampler, Estimator, BackendSampler, BackendEstimator_expand_parametersinqiskit/compiler/assembler.pyDefaultUnitarySynthesistranspiler passUnrollForLoopstranspiler passI don't think these checks would be needed, but let me know if you disagree.
I was also unsure about modifying the
qiskit.algorithmsrelated code, as it is going to be removed anyway, but honestly the search and replace was pretty much 0 effort compared to catching the deprecation warnings or creating exceptions in the test case. I have in any case done this in a separate commit in case we think it should be reverted.