Revert "Pass manager refactoring: add passmanager module (#10124)" #10454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit fbd64d9. The follow on PR to this one Qiskit#10127 which is making internal refactors to the pass manager code now that's it a standalone module is still undergoing active review and the scope of the PR is sufficiently large that it likely won't be viable for the pending 0.25.0 release. This commit temporarily reverts Qiskit#10124 which was the first step of creating a module by porting the pass manager code in it's current form to a standalone module so that we're not committed to the API as part of the 0.25.0 release to give more time for Qiskit#10127 to finalize what the eventual `qiskit.passmanager` API will look like. This revert should itself be reverted after 0.25.0rc1 is tagged and the main branch opens up for 0.45.0 development. As this revert is not an indication that we did not want Qiskit#10124 it's just to avoid committing to the API prematurely.
|
One or more of the the following people are requested to review this:
|
nkanazawa1989
approved these changes
Jul 20, 2023
Pull Request Test Coverage Report for Build 5612196899
💛 - Coveralls |
kevinhartman
approved these changes
Jul 20, 2023
to24toro
pushed a commit
to to24toro/qiskit-terra
that referenced
this pull request
Aug 3, 2023
…" (Qiskit#10454) This reverts commit fbd64d9. The follow on PR to this one Qiskit#10127 which is making internal refactors to the pass manager code now that's it a standalone module is still undergoing active review and the scope of the PR is sufficiently large that it likely won't be viable for the pending 0.25.0 release. This commit temporarily reverts Qiskit#10124 which was the first step of creating a module by porting the pass manager code in it's current form to a standalone module so that we're not committed to the API as part of the 0.25.0 release to give more time for Qiskit#10127 to finalize what the eventual `qiskit.passmanager` API will look like. This revert should itself be reverted after 0.25.0rc1 is tagged and the main branch opens up for 0.45.0 development. As this revert is not an indication that we did not want Qiskit#10124 it's just to avoid committing to the API prematurely.
to24toro
pushed a commit
to to24toro/qiskit-terra
that referenced
this pull request
Aug 3, 2023
…kit#10124)" (Qiskit#10454)" (Qiskit#10474) This reverts commit c03e4c7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This reverts commit fbd64d9. The follow on PR to this one #10127 which is making internal refactors to the pass manager code now that's it a standalone module is still undergoing active review and the scope of the PR is sufficiently large that it likely won't be viable for the pending 0.25.0 release. This commit temporarily reverts #10124 which was the first step of creating a module by porting the pass manager code in it's current form to a standalone module so that we're not committed to the API as part of the 0.25.0 release to give more time for #10127 to finalize what the eventual
qiskit.passmanagerAPI will look like.This revert should itself be reverted after 0.25.0rc1 is tagged and the main branch opens up for 0.45.0 development. As this revert is not an indication that we did not want #10124 it's just to avoid committing to the API prematurely.
Details and comments