Add proxy pass through test

[nonhermitian]

Summary

Test is bad proxy info raises proxyerror in the API. This means we correctly pass the proxies dict to the API. Note that this test takes a while because the API does not check if a connection can be established before trying the max number of times.

Details and comments

[diego-plan9]

Thanks for the speedy PR!

Can you also take the chance to update the proxies= argument in test_enable_account and test_save_account? They were included as a safety for the proxy handling, but they have the incorrect format.

[diego-plan9]

Can you replace the host with either an invalid one, or one that resolves quickly: perhaps 127.0.0.1? This way hopefully we avoid the delay, while still getting the error.

[nonhermitian]

ok

[nonhermitian]

The issue is really not the url that is being connected to, but rather the requests module does not care if it cannot establish a connection, it keeps trying up until the max number of connection attempts is made. See issue #992

[diego-plan9]

The issue is really not the url that is being connected to, but rather the requests module does not care if it cannot establish a connection, it keeps trying up until the max number of connection attempts is made. See issue #992

Hmm sounds odd - running the tests locally with 127.0.0.1 results in it passing in less than a second, which is actually sort of consistent with your explanation: it attempts to open a connection to the proxy a number of times (which instantly fail), and gives up after max_retries attempts. Do you have a proxy yourself on that port?

Anyway, seems part of another issue indeed - the PR itself is looking ready!