Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qiskit/mapper/_coupling.py needs more testing #770

Closed
1ucian0 opened this issue Aug 10, 2018 · 0 comments · Fixed by #784
Closed

qiskit/mapper/_coupling.py needs more testing #770

1ucian0 opened this issue Aug 10, 2018 · 0 comments · Fixed by #784
Labels
good first issue Good for newcomers type: qa Issues and PRs that relate to testing and code quality

Comments

@1ucian0
Copy link
Member

1ucian0 commented Aug 10, 2018

What is the expected enhancement?

The coupling graph structure in qiskit/mapper/_coupling.py is currently not very well tested. Please, add more tests.
@1ucian0 1ucian0 added good first issue Good for newcomers type: qa Issues and PRs that relate to testing and code quality labels Aug 10, 2018
@1ucian0 1ucian0 mentioned this issue Aug 10, 2018
Merged
@mtreinish mtreinish mentioned this issue Aug 16, 2018
Merged
mtreinish added a commit to mtreinish/qiskit-core that referenced this issue Aug 16, 2018
@mtreinish
Add tests for qiskit.mapper._coupling module
065ae22 
This commit adds test coverage for the qiskit.mapper.__coupling. During
the testing some unhandled edge cases were found in the module, this
commit also fixes those at the same time.

Fixes Qiskit#770
ajavadia pushed a commit that referenced this issue Aug 17, 2018
@mtreinish @ajavadia
Add tests for qiskit.mapper._coupling module (#784)
76b7ad9 
This commit adds test coverage for the qiskit.mapper.__coupling. During
the testing some unhandled edge cases were found in the module, this
commit also fixes those at the same time.

Fixes #770
lia-approves pushed a commit to edasgupta/qiskit-terra that referenced this issue Jul 30, 2019
@mtreinish @ajavadia
Add tests for qiskit.mapper._coupling module (Qiskit#784)
c874b98 
This commit adds test coverage for the qiskit.mapper.__coupling. During
the testing some unhandled edge cases were found in the module, this
commit also fixes those at the same time.

Fixes Qiskit#770
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers type: qa Issues and PRs that relate to testing and code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add tests for qiskit.mapper._coupling module mtreinish/qiskit-core
1 participant
@1ucian0