Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.0.0 version not working in both Android and IOS #29

Closed
venkata-reddy-dev opened this issue Mar 8, 2021 · 8 comments
Closed

3.0.0 version not working in both Android and IOS #29

venkata-reddy-dev opened this issue Mar 8, 2021 · 8 comments

Comments

@venkata-reddy-dev
Copy link

Android error log
Screenshot 2021-03-08 at 5 39 46 AM

Ios error log
Screenshot 2021-03-08 at 5 35 16 AM

Android gradle build error log
Screenshot 2021-03-08 at 5 38 44 AM

Note :
Screenshot 2021-03-08 at 5 40 45 AM

  1. Not working when i am using version 3.0.0
  2. Working as expected when i am pointing to git url
@fzyzcjy
Copy link
Contributor

fzyzcjy commented Mar 8, 2021

is the example app run sucessfully?

@venkata-reddy-dev
Copy link
Author

venkata-reddy-dev commented Mar 8, 2021

@fzyzcjy issue reproduced in example project

please see line no : 19 replaced path with latest version and error log in console

Screenshot 2021-03-08 at 7 25 38 AM

Note : I am thinking there may be something went wrong in release process

@fzyzcjy
Copy link
Contributor

fzyzcjy commented Mar 8, 2021

Hmm my null-safety migration seems to be unrelated with this.

Maybe caused by this merge? 11c9dcd

@Purus

@nohli nohli mentioned this issue Mar 8, 2021
@nohli
Copy link

nohli commented Mar 8, 2021

Could you try? It should fix it :)

  launch_review:
    git:
      url: https://github.com/nohli/launch_review
      ref: fix-flutter-2

@venkata-reddy-dev
Copy link
Author

venkata-reddy-dev commented Mar 8, 2021

@nohli i could test it when it is available in pub.dev along with your changes. because when i am pointing to git repo as dependency i am not facing any issues

cc: @Purus , @fzyzcjy

@nohli
Copy link

nohli commented Mar 8, 2021

Edit: the new version has a fix.

@RR-Reddy so maybe the issue is not in this code...

I just downloaded the pub.dev version and there were 84 changed files compared to this repo's master.

For example (red is this repo, green the pub.dev version):

1

Maybe the added 'platforms' part is wrong.

@fzyzcjy
Copy link
Contributor

fzyzcjy commented Mar 10, 2021

@RR-Reddy So does 3.0.1 work for you?

@venkata-reddy-dev
Copy link
Author

@fzyzcjy

Working fine.

i have tested in both Android and IOS just now.

Thanks to all for fixing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants