-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix job editor switches to the snapshot version when body is changed #2319
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2319 +/- ##
==========================================
- Coverage 89.73% 89.72% -0.01%
==========================================
Files 298 298
Lines 10039 10038 -1
==========================================
- Hits 9008 9007 -1
Misses 1031 1031 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@midigofrank this is looking good to me, great job 👏. I left a comment but up to you to handle it or not.
@@ -78,6 +78,8 @@ defmodule LightningWeb.WorkflowLive.EditorPane do | |||
{:noreply, socket} | |||
end | |||
|
|||
# NOTE: This is dead code and should probably be removed. All events are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should remove it in this work, what do you think ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't feel confident enough to remove it at this time. I was thinking of removing it as a follow-up when everything is tested and works fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Loooooveeee eeeeeett!!
Thanks mate!
Description
This PR fixes the bug on the inspector that switches the job editor back to the snapshot version whenever the user types anything in. You can check the issue #2306 for a video on this
Closes #2306
Closes #2308
Validation steps
In order to validate this, we'll need to have a workflow with at least one job in it.
We'll create a manual work order using the job as it is, then later update the job body to have something else.
This way, we'll have a work order with an older version of the job body.
These instructions assume you've done the the above
Pre-submission checklist
:owner
,:admin
,:editor
,:viewer
)