Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make root layout configurable #2310

Merged
merged 4 commits into from
Jul 30, 2024
Merged

Make root layout configurable #2310

merged 4 commits into from
Jul 30, 2024

Conversation

midigofrank
Copy link
Collaborator

@midigofrank midigofrank commented Jul 19, 2024

Description

  • This PR makes the root layout configurable. This way we can use another root layout in thunderbolt.
  • It also introduces a slot for additional header tags to be injected
  • Pushes a workflow created event which is handled in js land

Validation steps

Check https://github.com/OpenFn/thunderbolt/pull/265 in order to test these changes.
At a minimum, everything should be working in Lightning as it was. The layout and workflow creation is not affected in any way

Pre-submission checklist

  • I have performed a self-review of my code.
  • I have implemented and tested all related authorization policies. (e.g., :owner, :admin, :editor, :viewer)
  • I have updated the changelog.

@midigofrank midigofrank changed the title configure root layout Make root layout configurable Jul 25, 2024
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.80%. Comparing base (f82dd42) to head (570f27c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2310      +/-   ##
==========================================
- Coverage   89.81%   89.80%   -0.01%     
==========================================
  Files         297      297              
  Lines       10133    10136       +3     
==========================================
+ Hits         9101     9103       +2     
- Misses       1032     1033       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@midigofrank midigofrank marked this pull request as ready for review July 25, 2024 13:03
@stuartc stuartc merged commit 5138287 into main Jul 30, 2024
8 checks passed
@stuartc stuartc deleted the configure-root-layout branch July 30, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants