-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve User Creation Form #1111
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1111 +/- ##
==========================================
+ Coverage 88.92% 89.38% +0.46%
==========================================
Files 186 186
Lines 5335 5342 +7
==========================================
+ Hits 4744 4775 +31
+ Misses 591 567 -24
☔ View full report in Codecov by Sentry. |
c25f72c
to
0173b39
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elias-ba well done 👏 this was a massive set of changes... It's looking great, excited for the rest of them to match the new stuff!
I have some comments on prefixing the fields name to all the error messages. So not rejecting right now - but I think we can solve it a little differently.
Hey @stuartc and @NickOpenFn this is looking now much better. I have introduced usage of gettext to translate Ecto errors to more humanized errors. Let me know if you need anymore change. |
Notes for the reviewer
This PR proposes code for improving how we render error messages in our forms and prepares for using the NewInput module as replacement to our old Form module.
Related issue
Fixes #731
Review checklist