Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in automatic organisation sharing when the user is part of the platform main organization #4836

Open
Lhorus6 opened this issue Nov 2, 2023 · 10 comments
Labels
feature use for describing a new feature to develop
Milestone

Comments

@Lhorus6
Copy link

Lhorus6 commented Nov 2, 2023

Description

If a user is part of the platform main organization, the entities they create will not be shared with the organizations to which they belong. Let me explain with this scenario:

Doesn't work

Configuration :

  • Org A is the platform main organization
  • User A part of Org A, B and C
  • User B part of Org B

Scenario :
User A create a report (same with malware for example) named "Test report" -> User B can't see the report + if User A look next to the orange share button on the report, he doesn't see "org B" and "Org C" as organizations with which the report is shared

Works

Configuration :

  • Neither Org A, B nor C are the platform main organization
  • User A part of Org A, B and C
  • User B part of Org B

Scenario :
User A create a report (same with malware for example) named "Test report" -> User B can see the report + if User A look next to the orange share button on the report, he see "Org A", "Org B" and "Org C" as organizations with which the report is shared (as expected)

Environment

OpenCTI 5.11.12

Reproducible Steps

See the description

@Lhorus6 Lhorus6 added the bug use for describing something not working as expected label Nov 2, 2023
@Lhorus6 Lhorus6 changed the title Bug in the management of automatic organisation shares Bug in the management of automatic organisation shares when user is part of the platform organization Nov 2, 2023
@Lhorus6 Lhorus6 changed the title Bug in the management of automatic organisation shares when user is part of the platform organization Bug in automatic organisation sharing when the user is part of the platform organization Nov 2, 2023
@Lhorus6 Lhorus6 changed the title Bug in automatic organisation sharing when the user is part of the platform organization Bug in automatic organisation sharing when the user is part of the platform main organization Nov 2, 2023
@Kedae Kedae self-assigned this Nov 3, 2023
@Kedae Kedae added needs triage use to identify issue needing triage from Filigran Product team and removed bug use for describing something not working as expected labels Nov 3, 2023
@Kedae
Copy link
Member

Kedae commented Nov 3, 2023

@Jipegien or @SamuelHassine Need your opinion

@richard-julien
Copy link
Member

My feeling.
Sharing information to platform organizations is useless.
Auto sharing with all the organizations of the users (except the platform one) seems ok for me.
So:

  • If user is part of A,B,C (with A as platforme orga), the element should be shared with B and C.
  • If user is part of A (with A as platforme orga), the element should not be shared
  • If user is part of B, the element should be shared with B

@Jipegien
Copy link
Member

Jipegien commented Nov 3, 2023

I am ok with that!

@SamuelHassine SamuelHassine added feature use for describing a new feature to develop and removed needs triage use to identify issue needing triage from Filigran Product team labels Nov 4, 2023
@SamuelHassine SamuelHassine modified the milestones: Release 5.12.0, Release 5.13.0 Nov 30, 2023
@SamuelHassine
Copy link
Member

@Jipegien @nino-filigran is it something scheduled for 5.13?

@nino-filigran
Copy link

No, it is not @SamuelHassine. Is that something to consider according to you?

@SamuelHassine
Copy link
Member

Yes, this is a tiny adjustment which is not requiring a lot of technical work but which aligns the behavior of the platform with a more meaningful usage.

@nino-filigran
Copy link

I'll discuss with @Jipegien on how/if we can fits this in and keep you posted on this ticket.

@nino-filigran
Copy link

@SamuelHassine the content of the 5.13 is quite packed at the moment. We would rather add it on the top of the list for the 5.14.

@Jipegien
Copy link
Member

Jipegien commented Dec 5, 2023

@nino-filigran I don't see this issue in the feature backlog. Did you add it?

@nino-filigran
Copy link

Great catch, it was on my todo. I'll do it this afternoon

@SamuelHassine SamuelHassine modified the milestones: Release 5.13.0, Release 6.0.0 Jan 16, 2024
@Jipegien Jipegien modified the milestones: Release 6.1.0, Short-term candidates Mar 10, 2024
@Jipegien Jipegien modified the milestones: Short-term candidates, Release 6.2.0 Mar 12, 2024
@Jipegien Jipegien modified the milestones: Release 6.2.0, Release 6.4.0 Mar 26, 2024
@Jipegien Jipegien modified the milestones: Release 6.4.0, Release 6.5.0 Apr 17, 2024
@SamuelHassine SamuelHassine added filigran team use to identify PR from the Filigran team and removed filigran team use to identify PR from the Filigran team labels Apr 20, 2024
@Kedae Kedae removed their assignment Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature use for describing a new feature to develop
Projects
None yet
Development

No branches or pull requests

6 participants