clamav: Fix check failure of clamscan no tests #326533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems like clamav uses `pytest` as a test runner preferentially, then falls back to `unittest`. For some reason `unittest` isn't discovering the tests inside clamav/unit_test/clamscan, and instead exitting with `sys.exit(_NO_TESTS_EXITCODE)`. I have checked actual `clamscan` tests are being run using `nix develop .#clamscan`, `genericBuild`, `checkPhase` then manually running `ctest -V`. Fixes NixOS#325510
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
labels
|
Result of 3 packages built:
|
khaneliman
approved these changes
Jul 12, 2024
KoviRobi
pushed a commit
to KoviRobi/nixos-config
that referenced
this pull request
Jul 13, 2024
Flake lock file updates:
• Updated input 'NixOS-WSL':
'github:nix-community/NixOS-WSL/269411cfed6aab694e46f719277c972de96177bb' (2024-06-24)
→ 'github:nix-community/NixOS-WSL/30ebd0beb2ed26e09bcd245d757504029f807cce' (2024-07-08)
• Updated input 'home-manager':
'github:nix-community/home-manager/58268b4d7745f6747be18033e6f10011466ce8d4' (2024-07-03)
→ 'github:nix-community/home-manager/90ae324e2c56af10f20549ab72014804a3064c7f' (2024-07-11)
• Updated input 'nix-index-database':
'github:nix-community/nix-index-database/2917972ed34ce292309b3a4976286f8b5c08db27' (2024-07-01)
→ 'github:nix-community/nix-index-database/685e40e1348007d2cf76747a201bab43d86b38cb' (2024-07-07)
• Updated input 'nixpkgs':
'github:NixOS/nixpkgs/0aeab749216e4c073cece5d34bc01b79e717c3e0' (2024-07-02)
→ 'github:KoviRobi/nixpkgs/3cd585c4caade13403f9dc8d0ec8ca0d85a4b63c' (2024-07-12)
The latter is 16e401f01842c5bb2499e78c1fe227f939c0c474 with
NixOS/nixpkgs#326533 picked on top
Wulfsta
approved these changes
Jul 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clamav wasn't building due to failing tests.
It seems like clamav uses
pytestas a test runner preferentially, then falls back tounittest. For some reasonunittestisn't discovering the tests inside clamav/unit_test/clamscan, and instead exitting withsys.exit(_NO_TESTS_EXITCODE).I have checked actual
clamscantests are being run usingnix develop .#clamscan,genericBuild,checkPhasethen manually runningctest -V.Fixes #325510
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.