aliyun-fcli: init at 1.0.3 #142809
Draft
aliyun-fcli: init at 1.0.3 #142809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ornxka
commented
Oct 25, 2021
| # see updatedeps.sh for how to generate this file | ||
| goDeps = ./deps.nix; | ||
|
|
||
| patches = [./uuiddep.patch]; |
There was a problem hiding this comment.
This patch changes the library for generating UUID's from https://github.com/satori/go.uuid to https://github.com/gofrs/uuid, a more active fork. The original library no longer compiles with this package, has not been updated since 2018, and has unpatched CVEs. This issue satori/go.uuid#115 explains the situation.
| @@ -0,0 +1,14 @@ | |||
| export GOPATH=$(mktemp -d /tmp/aliyunfcli.XXXXXX) | |||
There was a problem hiding this comment.
Please wire this into the package as an update script using nix-shell.
| git clone https://github.com/aliyun/fcli | ||
| cd fcli | ||
| git checkout 996ceb142c237d7010c58e349decd7e4ed96c117 | ||
| git apply /path/to/your/local/nixpkgs/pkgs/tools/admin/aliyun-fcli/uuiddep.patch |
There was a problem hiding this comment.
Please use working paths.
| git apply /path/to/your/local/nixpkgs/pkgs/tools/admin/aliyun-fcli/uuiddep.patch | ||
| glide install | ||
| go mod init github.com/aliyun/fcli | ||
| go mod tidy |
There was a problem hiding this comment.
If we do go mod here the package could also use buildGoModule.
stale
bot
added
the
2.status: stale
stale
bot
removed
the
2.status: stale
wegank
added
2.status: stale
stale
bot
removed
the
2.status: stale
wegank
added
the
2.status: stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
aliyun-fcli is a CLI tool to help manage Function Compute resources in Alibaba Cloud.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)