Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Ability to Set the Hotbar Slot for the Sprinkler #44

Open
thesinmin opened this issue Nov 25, 2023 · 5 comments
Open

Add the Ability to Set the Hotbar Slot for the Sprinkler #44

thesinmin opened this issue Nov 25, 2023 · 5 comments
Assignees
Labels
suggestion New feature or request

Comments

@thesinmin
Copy link

Have you searched the existing suggestions?

Yes

What is your suggestion?

Rather than the current hard-coded expectation of a user having the sprinkler in slot 1 of the hotbar, I'd suggest adding an option to set it to any slot.

How will this improve Natro Macro?

People who have their hotbars setup differently would not have to re-learn their hot keys after implementing Natro.

Note that I have added this to several versions locally but getting it into the actual code would save me having to update the macro each time a new version comes out and would make it available to any others who might be weird work differently like I do.

Note2: I'm happy to work on coding this if the idea is acceptable to the team. This would be my first open-source submission, so I'm not promising an immediate turnaround.

What is your Discord username?

SinMin#7776

@thesinmin thesinmin added needs triage This issue needs to be verified by the Gumdrop Gang suggestion New feature or request labels Nov 25, 2023
@Axetar
Copy link

Axetar commented Nov 25, 2023

Yeah! Go ahead an make a pull request!

@Axetar Axetar closed this as completed Nov 25, 2023
@Axetar Axetar removed the needs triage This issue needs to be verified by the Gumdrop Gang label Nov 25, 2023
@zspz
Copy link
Contributor

zspz commented Nov 25, 2023

I'm reopening this because it is a good suggestion and would simplify things a lot. I am still seeing newer users have other items wrongly set to hotbar slot 1 when using the macro.

Instead of having the option to set it (which can still lead to users choosing the wrong option / forgetting to set it), I would instead detect which slot the sprinkler is in and save that for use throughout the macro.

@zspz zspz reopened this Nov 25, 2023
@thesinmin
Copy link
Author

thesinmin commented Nov 26, 2023

That sounds like a great idea. Guess it's time for me to read up on the gdip library,
With that said, would it then make sense to just assign the hotbar items at startup rather than leaving it to the user to choose each one?

@zspz
Copy link
Contributor

zspz commented Dec 5, 2023

@thesinmin
Sorry for the incredibly late response! I didn't see this comment.
Yes, I think that can definitely be added in a future update, instead of assigning slots 2-7 as users currently do in Boost tab.
This would require some extra consideration, including how the user can set options for dynamic slots.
So I think it would be fine to detect Sprinkler on startup (i.e. after the ;check UIPI section) for now, and assign that slot to a global variable (between sc002 (1) and sc008 (7)) which is called instead of Send {%SC_1%}.

@peacocksir peacocksir self-assigned this Aug 8, 2024
@peacocksir
Copy link
Contributor

im going to be working on this

@Noobyguy775 Noobyguy775 self-assigned this Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
suggestion New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants