Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update transl de #374

Merged
merged 7 commits into from
May 26, 2023
Merged

Update transl de #374

merged 7 commits into from
May 26, 2023

Conversation

DGrothe-PhD
Copy link
Contributor

✅ I have read the contributing file

Summary

  • German translation slightly amended and completed
  • Fixed a typo in English - please see detail below

Changelog

  • German translation slightly amended and completed all of de.json files
  • Fixed a typo in English "ABOUT_SCREEN_LIBRARIES_AND_CONTRIBUTORS": "Libraries & contributors"
    (I just removed the extra 'i' there)
    PLEASE NOTE: I did not change the "Librairies..." occurrence in /app/screens/About/__tests__/__snapshots__/AboutScreen.test.tsx.snap (looks as if automatically generated).

Just let me know if anything is not okay.

@ghost
Copy link

ghost commented May 24, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks huge but tokens are same order as in the English json. This helped in finding what is missing and will help to make future amendments.

@PierreBresson PierreBresson merged commit def1aeb into NMF-earth:main May 26, 2023
@PierreBresson
Copy link
Member

@DGrothe-PhD Danke schön! I've also pushed the translations to poeditor 😊

@DGrothe-PhD DGrothe-PhD deleted the updateTranslDE branch May 28, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants