failed modify setting in .code-workspace

[sumneko]

@sumneko

@lhemkendreis I just test it and seems works well. What's your extension version? Is there any error in output?

Thanks for the quick reply and especially for the GIF! That behavior was exactly what I expected, but just didn't happen for me. My extension version is sumneko.lua-2.2.3 and I just reinstalled it just because of this issue.

I did a new test and suddenly it did work! Then I did some further testing. The behavior seems to be as follows.

• When I don't save the workspace and just work in a folder, then it works as expected. The settings are applied to the local .vscode/settings.json file. I.e. exactly like you showed in your reply.

• When I do save the workspace in a workspace configuration file (suffix .code-workspace) then it does not work as expected. In this case it only modifies the setting in the workspace configuration file - which would be fine, except that it only applies the setting "Lua.workspace.checkThirdParty": false and nothing else :-(

Conclusion: It does work but not with saved workspaces. Is that intended?

Originally posted by @lhemkendreis in #409 (comment)