Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pytorch-lightning requirement from <2.0.0,>=1.4 to >=1.4,<3.0.0 in /_requirements #243

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 1, 2023

Updates the requirements on pytorch-lightning to permit the latest version.

Release notes

Sourced from pytorch-lightning's releases.

2.0.1 patch release

App

No changes


Fabric

Changed

  • Generalized Optimizer validation to accommodate both FSDP 1.x and 2.x (#16733)

PyTorch

Changed

  • Pickling the LightningModule no longer pickles the Trainer (#17133)
  • Generalized Optimizer validation to accommodate both FSDP 1.x and 2.x (#16733)
  • Disable torch.inference_mode with torch.compile in PyTorch 2.0 (#17215)

Fixed

  • Fixed issue where pickling the module instance would fail with a DataLoader error (#17130)
  • Fixed WandbLogger not showing "best" aliases for model checkpoints when ModelCheckpoint(save_top_k>0) is used (#17121)
  • Fixed the availability check for rich that prevented Lightning to be imported in Google Colab (#17156)
  • Fixed parsing the precision config for inference in DeepSpeedStrategy (#16973)
  • Fixed issue where torch.compile would fail when logging to WandB (#17216)

Contributors

@​Borda @​williamFalcon @​lightningforever @​adamjstewart @​carmocca @​tshu-w @​saryazdi @​parambharat @​awaelchli @​colehawkins @​woqidaideshi @​md-121 @​yhl48 @​gkroiz @​idc9 @​speediedan

If we forgot someone due to not matching commit email with GitHub account, let us know :]

Commits

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added the ci/cd label Apr 1, 2023
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 1, 2023

Dependabot tried to add @Lightning-AI/core-lightning as a reviewer to this PR, but received the following error from GitHub:

POST https://api.github.com/repos/Lightning-AI/tutorials/pulls/243/requested_reviewers: 422 - Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the Lightning-AI/tutorials repository. // See: https://docs.github.com/rest/reference/pulls#request-reviewers-for-a-pull-request

@codecov
Copy link

codecov bot commented Apr 1, 2023

Codecov Report

Merging #243 (68ee6c8) into main (68be91f) will not change coverage.
The diff coverage is n/a.

❗ Current head 68ee6c8 differs from pull request most recent head 0e3cb57. Consider uploading reports for the commit 0e3cb57 to get more accurate results

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #243   +/-   ##
===================================
  Coverage    73%    73%           
===================================
  Files         2      2           
  Lines       382    382           
===================================
  Hits        280    280           
  Misses      102    102           

@dependabot dependabot bot force-pushed the dependabot-pip-_requirements-pytorch-lightning-gte-1.4-and-lt-3.0.0 branch from fdf78db to e8b8917 Compare April 1, 2023 14:28
Updates the requirements on [pytorch-lightning](https://github.com/Lightning-AI/lightning) to permit the latest version.
- [Release notes](https://github.com/Lightning-AI/lightning/releases)
- [Commits](Lightning-AI/pytorch-lightning@1.4.0...2.0.1)

---
updated-dependencies:
- dependency-name: pytorch-lightning
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot-pip-_requirements-pytorch-lightning-gte-1.4-and-lt-3.0.0 branch from e8b8917 to 68ee6c8 Compare April 7, 2023 06:02
@mergify mergify bot added the has conflicts label May 3, 2023
_requirements/default.txt Outdated Show resolved Hide resolved
@mergify mergify bot removed the has conflicts label May 3, 2023
@Borda Borda merged commit 268f52a into main May 3, 2023
@Borda Borda deleted the dependabot-pip-_requirements-pytorch-lightning-gte-1.4-and-lt-3.0.0 branch May 3, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant