Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unify configs in pyproject & ruff #224

Merged
merged 19 commits into from
Mar 24, 2023
Merged

unify configs in pyproject & ruff #224

merged 19 commits into from
Mar 24, 2023

Conversation

Borda
Copy link
Member

@Borda Borda commented Jan 25, 2023

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

unify all python related configs in pyproject.toml
replace flake8 by ruff

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

Merging #224 (5465056) into main (7e3565d) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #224   +/-   ##
===================================
  Coverage    73%    73%           
===================================
  Files         2      2           
  Lines       382    382           
===================================
  Hits        280    280           
  Misses      102    102           

@Borda
Copy link
Member Author

Borda commented Jan 25, 2023

let's wait the PL update is resolved in #222

Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

.pre-commit-config.yaml Outdated Show resolved Hide resolved
Co-authored-by: Akihiro Nitta <[email protected]>
@mergify mergify bot added the has conflicts label Mar 1, 2023
@Borda Borda enabled auto-merge (squash) March 24, 2023 14:28
@mergify mergify bot removed the has conflicts label Mar 24, 2023
@Borda Borda disabled auto-merge March 24, 2023 15:28
@Borda Borda merged commit 4327b88 into main Mar 24, 2023
@Borda Borda deleted the pyproject branch March 24, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants