Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check that AS was built and TOP_LEVEL #7580

Open
spencer-lunarg opened this issue Feb 26, 2024 · 0 comments
Open

Add check that AS was built and TOP_LEVEL #7580

spencer-lunarg opened this issue Feb 26, 2024 · 0 comments
Assignees
@arno-lunarg
Labels
GPU-AV GPU Assisted Validation Incomplete Missing Validation VUs to be added

Comments

@spencer-lunarg
Copy link
Contributor

Add support for

  • VUID-RuntimeSpirv-OpRayQueryInitializeKHR-06352
  • VUID-RuntimeSpirv-OpTraceRayKHR-06359

As described in https://gitlab.khronos.org/vulkan/vulkan/-/issues/3799 these VUs should report

  1. When trying to access, the AS has not been built yet
  2. If it was built, make sure it is TOP_LEVEL (if was created with VK_ACCELERATION_STRUCTURE_TYPE_GENERIC_KHR and then built later with BOTTOM it should report an error)

For 1, we will need to be aware of the it is being built on the device prior to the CmdTraceRays call
@spencer-lunarg spencer-lunarg added the Incomplete Missing Validation VUs to be added label Feb 26, 2024
@arno-lunarg arno-lunarg added the GPU-AV GPU Assisted Validation label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arno-lunarg arno-lunarg

Labels
GPU-AV GPU Assisted Validation Incomplete Missing Validation VUs to be added
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arno-lunarg @spencer-lunarg