feat(versions): updated dependencies versions and fixed tslint errors

Ismaestro · Dec 7, 2017 · 64e5d94 · 64e5d94
1 parent 0c4c685
commit 64e5d94
Show file tree

Hide file tree

Showing 7 changed files with 1,961 additions and 2,048 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -22,33 +22,33 @@
     "npm": ">= 3.0.0"
   },
   "dependencies": {
-    "@angular/animations": "5.0.0",
-    "@angular/common": "5.0.0",
-    "@angular/compiler": "5.0.0",
-    "@angular/core": "5.0.0",
+    "@angular/animations": "5.1.0",
+    "@angular/common": "5.1.0",
+    "@angular/compiler": "5.1.0",
+    "@angular/core": "5.1.0",
     "@angular/flex-layout": "2.0.0-beta.10-4905443",
-    "@angular/forms": "5.0.0",
-    "@angular/http": "5.0.0",
-    "@angular/platform-browser": "5.0.0",
-    "@angular/platform-browser-dynamic": "5.0.0",
-    "@angular/router": "5.0.0",
+    "@angular/forms": "5.1.0",
+    "@angular/http": "5.1.0",
+    "@angular/platform-browser": "5.1.0",
+    "@angular/platform-browser-dynamic": "5.1.0",
+    "@angular/router": "5.1.0",
     "classlist.js": "1.1.20150312",
     "core-js": "2.5.1",
-    "rxjs": "5.5.2",
+    "rxjs": "5.5.5",
     "zone.js": "0.8.18"
   },
   "devDependencies": {
-    "@angular/cdk": "2.0.0-beta.12",
-    "@angular/cli": "1.5.0",
-    "@angular/compiler-cli": "5.0.0",
-    "@angular/material": "2.0.0-beta.12",
-    "@angular/platform-server": "5.0.0",
-    "@ngx-translate/core": "8.0.0",
+    "@angular/cdk": "5.0.0",
+    "@angular/cli": "1.6.0",
+    "@angular/compiler-cli": "5.1.0",
+    "@angular/material": "5.0.0",
+    "@angular/platform-server": "5.1.0",
+    "@ngx-translate/core": "9.0.1",
     "@ngx-translate/http-loader": "2.0.0",
-    "@types/jasmine": "2.6.2",
+    "@types/jasmine": "2.8.2",
     "@types/jasminewd2": "2.0.3",
-    "@types/node": "8.0.48",
-    "angular-cli-ghpages": "0.5.1",
+    "@types/node": "8.0.56",
+    "angular-cli-ghpages": "0.5.2",
     "codelyzer": "4.0.1",
     "coveralls": "3.0.0",
     "hammerjs": "2.0.8",
@@ -58,10 +58,10 @@
     "karma-chrome-launcher": "2.2.0",
     "karma-cli": "1.0.1",
     "karma-coverage-istanbul-reporter": "1.3.0",
-    "karma-jasmine": "1.1.0",
+    "karma-jasmine": "1.1.1",
     "karma-jasmine-html-reporter": "0.2.2",
     "karma-remap-istanbul": "0.6.0",
-    "protractor": "5.2.0",
+    "protractor": "5.2.1",
     "source-map-explorer": "1.5.0",
     "standard-version": "4.2.0",
     "ts-helpers": "1.1.2",

diff --git a/src/app/app.component.ts b/src/app/app.component.ts
@@ -51,7 +51,7 @@ export class AppComponent {
 
   checkBrowserFeatures() {
     let supported = true;
-    for (let feature in Modernizr) {
+    for (const feature in Modernizr) {
       if (Modernizr.hasOwnProperty(feature) &&
         typeof Modernizr[feature] === 'boolean' && Modernizr[feature] === false) {
         supported = false;

diff --git a/src/app/core/search-bar/search-bar.component.spec.ts b/src/app/core/search-bar/search-bar.component.spec.ts
@@ -50,7 +50,7 @@ describe('SearchBarComponent', () => {
     tick();
     fixture.detectChanges();
     expect(component.defaultHeroes.length).toBeGreaterThan(0);
-    for (let hero of component.defaultHeroes) {
+    for (const hero of component.defaultHeroes) {
       expect(hero.default).toBe(true);
     }
   }));

diff --git a/src/app/heroes/hero-list/hero-list.component.ts b/src/app/heroes/hero-list/hero-list.component.ts
@@ -7,6 +7,16 @@ import {AppConfig} from '../../config/app.config';
 import {Router} from '@angular/router';
 import {LoggerService} from '../../core/logger.service';
 
+@Component({
+  selector: 'app-remove-hero-dialog',
+  templateUrl: './remove-hero.dialog.html',
+})
+
+export class RemoveHeroDialogComponent {
+  constructor() {
+  }
+}
+
 @Component({
   selector: 'app-hero-list',
   templateUrl: './hero-list.component.html',
@@ -64,7 +74,7 @@ export class HeroListComponent {
   }
 
   remove(heroToRemove: Hero): void {
-    let dialogRef = this.dialog.open(RemoveHeroDialogComponent);
+    const dialogRef = this.dialog.open(RemoveHeroDialogComponent);
     dialogRef.afterClosed().subscribe(result => {
       if (result) {
         this.heroService.deleteHeroById(heroToRemove.id).subscribe(() => {
@@ -79,13 +89,3 @@ export class HeroListComponent {
     });
   }
 }
-
-@Component({
-  selector: 'app-remove-hero-dialog',
-  templateUrl: './remove-hero.dialog.html',
-})
-
-export class RemoveHeroDialogComponent {
-  constructor() {
-  }
-}
diff --git a/src/polyfills.ts b/src/polyfills.ts
@@ -79,10 +79,12 @@ import 'zone.js/dist/zone';  // Included with Angular CLI.
  * CUSTOM IMPORTS
  */
 import 'rxjs/add/observable/throw';
-
+import 'rxjs/add/observable/forkJoin';
+import 'rxjs/add/operator/filter';
 import 'rxjs/add/operator/catch';
 import 'rxjs/add/operator/startWith';
 import 'rxjs/add/operator/do';
+import 'rxjs/add/operator/map';
 
 
 /**

diff --git a/tslint.json b/tslint.json
@@ -1,38 +1,99 @@
 {
+  "rulesDirectory": [
+    "node_modules/codelyzer"
+  ],
   "rules": {
-    "max-line-length": [true, 150],
-    "no-inferrable-types": true,
+    "arrow-return-shorthand": true,
+    "callable-types": true,
     "class-name": true,
     "comment-format": [
       true,
       "check-space"
     ],
+    "curly": true,
+    "eofline": true,
+    "forin": true,
+    "import-blacklist": [
+      true,
+      "rxjs",
+      "rxjs/Rx"
+    ],
+    "import-spacing": true,
     "indent": [
       true,
       "spaces"
     ],
-    "eofline": true,
-    "no-duplicate-variable": true,
-    "no-eval": true,
+    "interface-over-type-literal": true,
+    "label-position": true,
+    "max-line-length": [
+      true,
+      140
+    ],
+    "member-access": false,
+    "member-ordering": [
+      true,
+      {
+        "order": [
+          "static-field",
+          "instance-field",
+          "static-method",
+          "instance-method"
+        ]
+      }
+    ],
     "no-arg": true,
-    "no-internal-module": true,
-    "no-trailing-whitespace": true,
     "no-bitwise": true,
+    "no-console": [
+      true,
+      "debug",
+      "info",
+      "time",
+      "timeEnd",
+      "trace"
+    ],
+    "no-construct": true,
+    "no-debugger": true,
+    "no-duplicate-super": true,
+    "no-empty": false,
+    "no-empty-interface": true,
+    "no-eval": true,
+    "no-inferrable-types": [
+      true,
+      "ignore-params"
+    ],
+    "no-misused-new": true,
+    "no-non-null-assertion": true,
+    "no-shadowed-variable": true,
+    "no-string-literal": false,
+    "no-string-throw": true,
+    "no-switch-case-fall-through": true,
+    "no-trailing-whitespace": true,
+    "no-unnecessary-initializer": true,
     "no-unused-expression": true,
+    "no-use-before-declare": true,
     "no-var-keyword": true,
+    "object-literal-sort-keys": false,
     "one-line": [
       true,
+      "check-open-brace",
       "check-catch",
       "check-else",
-      "check-open-brace",
       "check-whitespace"
     ],
+    "prefer-const": true,
     "quotemark": [
       true,
-      "single",
-      "avoid-escape"
+      "single"
+    ],
+    "radix": true,
+    "semicolon": [
+      true,
+      "always"
+    ],
+    "triple-equals": [
+      true,
+      "allow-null-check"
     ],
-    "semicolon": [true, "always"],
     "typedef-whitespace": [
       true,
       {
@@ -43,21 +104,37 @@
         "variable-declaration": "nospace"
       }
     ],
-    "curly": true,
-    "variable-name": [
-      true,
-      "ban-keywords",
-      "check-format",
-      "allow-leading-underscore",
-      "allow-pascal-case"
-    ],
+    "typeof-compare": true,
+    "unified-signatures": true,
+    "variable-name": false,
     "whitespace": [
       true,
       "check-branch",
       "check-decl",
       "check-operator",
       "check-separator",
       "check-type"
-    ]
+    ],
+    "directive-selector": [
+      true,
+      "attribute",
+      "app",
+      "camelCase"
+    ],
+    "component-selector": [
+      true,
+      "element",
+      "app",
+      "kebab-case"
+    ],
+    "use-input-property-decorator": true,
+    "use-output-property-decorator": true,
+    "use-host-property-decorator": true,
+    "no-input-rename": true,
+    "no-output-rename": true,
+    "use-life-cycle-interface": true,
+    "use-pipe-transform-interface": true,
+    "component-class-suffix": true,
+    "directive-class-suffix": true
   }
-}
+}