refactor ConsumerMetadataReq/Resp -> FindCoordinatorReq/Resp #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eapache
reviewed
Jan 19, 2018
find_coordinator_response.go
Outdated
| Coordinator *Broker | ||
| CoordinatorID int32 // deprecated: use Coordinator.ID() | ||
| CoordinatorHost string // deprecated: use Coordinator.Addr() | ||
| CoordinatorPort int32 // deprecated: use Coordinator.Addr() |
There was a problem hiding this comment.
Can we take this opportunity to remove these, since this is technically a new struct?
|
Thanks! Sorry I kind of forgot about this PR for a while. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of
KIP-98and for the impl of the transactional producer theGroupCoordinatorRequest/ConsumerMetadataRequesthas been renamedFindCoordinatorRequestand now serves the dual purpose of both looking up consumer group and transaction coordinator.This PR moves the logic to
FindCoordinatorRequest, transitionsgetConsumerMetadatato useFindCoordinatorRequest, and provides transparent backwards compatibility for theConsumerMetadataRequest.