Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnuradio 3.8.0.0 #44870

Closed
wants to merge 1 commit into from
Closed

gnuradio 3.8.0.0 #44870

wants to merge 1 commit into from

Conversation

icpz
Copy link
Contributor

@icpz icpz commented Oct 3, 2019

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Big changes! Gnuradio 3.8 migrate to qt5 finally... We can use gnuradio-companion with brewed formula now.

This update breaks many things, and exists minor bugs even it's already a release version.

One issue breaks the original gr_modtool test, so I temporarily removed related test.

@chenrui333
Copy link
Member

16:27:50 -- Python checking for python2 >= 2.7.6 or python3 >= 3.6.5 - found
16:27:50 -- Python checking for PyYAML >= 3.10 - found
16:27:50 -- Python checking for mako >= 0.9.1 - found
16:27:50 -- Python checking for pygobject >= 2.28.6 - found
16:27:50 -- Python checking for Gtk (GI) >= 3.10.8 - not found
16:27:50 -- Python checking for Cairo (GI) >= 1.0 - found
16:27:50 -- Python checking for PangoCairo (GI) >= 1.0 - found
16:27:50 -- Python checking for numpy - found
16:27:50 --
16:27:50 -- Configuring gnuradio-companion support...
16:27:50 -- Dependency ENABLE_GNURADIO_RUNTIME = ON
16:27:50 -- Dependency ENABLE_PYTHON = ON
16:27:50 -- Dependency PYTHON_MIN_VER_FOUND = TRUE
16:27:50 -- Dependency PYYAML_FOUND = TRUE
16:27:50 -- Dependency MAKO_FOUND = TRUE
16:27:50 -- Dependency PYGI_FOUND = TRUE
16:27:50 -- Dependency GTK_GI_FOUND = FALSE
16:27:50 -- Dependency CAIRO_GI_FOUND = TRUE
16:27:50 -- Dependency PANGOCAIRO_GI_FOUND = TRUE
16:27:50 -- Dependency NUMPY_FOUND = TRUE
16:27:50 CMake Error at cmake/Modules/GrComponent.cmake:75 (message):
16:27:50 user force-enabled gnuradio-companion but configuration checked failed
16:27:50 Call Stack (most recent call first):
16:27:50 grc/CMakeLists.txt:95 (GR_REGISTER_COMPONENT)
16:27:50
16:27:50
16:27:50 -- Configuring incomplete, errors occurred!
16:27:50 See also "/tmp/gnuradio-20191003-89349-1w9ofj0/gnuradio-3.8.0.0/build/CMakeFiles/CMakeOutput.log".
16:27:50 See also "/tmp/gnuradio-20191003-89349-1w9ofj0/gnuradio-3.8.0.0/build/CMakeFiles/CMakeError.log".

@chenrui333 chenrui333 added the build failure CI fails while building the software label Oct 3, 2019
@icpz icpz force-pushed the gnuradio branch 2 times, most recently from f8db32f to b577374 Compare October 4, 2019 09:36
@icpz
Copy link
Contributor Author

icpz commented Oct 4, 2019

How to resolve this?

gnuradio:
  * python modules have explicit framework links
    These python extension modules were linked directly to a Python
    framework binary. They should be linked with -undefined dynamic_lookup
    instead of -lpython or -framework Python.
      /usr/local/opt/gnuradio/lib/python3.7/site-packages/pmt/_pmt_swig.so
...

The cmake script automatically looks for python dynamic binary.

@icpz
Copy link
Contributor Author

icpz commented Oct 8, 2019

@chenrui333
Sorry to bother you... May I get some advice to resolve this python link issue?

@chenrui333
Copy link
Member

@kaslr I think @Moisan can help on this. :)

@jonchang
Copy link
Contributor

jonchang commented Oct 9, 2019

#43753

@fxcoudert fxcoudert mentioned this pull request Nov 22, 2019
62 tasks
@Bo98
Copy link
Member

Bo98 commented Nov 23, 2019

Let's revisit this after Python 3.8 (#45337).

@Bo98 Bo98 added do not merge python Python use is a significant feature of the PR or issue labels Nov 23, 2019
@icpz
Copy link
Contributor Author

icpz commented Nov 23, 2019

The required formula uhd won't build on catalina, I think it should be revisited before this.

@Bo98
Copy link
Member

Bo98 commented Nov 23, 2019

I'll have a look - I didn't see any prior mention of that in this pull request.

@icpz
Copy link
Contributor Author

icpz commented Nov 23, 2019

Here is the PR #45110 , that path issue seems catalina only...

@Bo98
Copy link
Member

Bo98 commented Nov 23, 2019

I've opened #47101 to investigate. Thanks for raising the issue.

@iMichka
Copy link
Member

iMichka commented Dec 14, 2019

I will migrate the current version to system python 2 in #47871 for the time being. This leaves you the time to sort this out, and allows us to delete the python@2 formula end of the year.

@fxcoudert
Copy link
Member

Closing due to lack of progress.

@fxcoudert fxcoudert closed this Dec 24, 2019
@lock lock bot added the outdated PR was locked due to age label Jan 24, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2020
@icpz icpz deleted the gnuradio branch May 14, 2021 16:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
build failure CI fails while building the software outdated PR was locked due to age python Python use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants