Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clients(devtools): require third-party-web to be provided #16166

Merged
merged 6 commits into from
Sep 5, 2024
Merged

Conversation

connorjclark
Copy link
Collaborator

We just need one copy of this. Otherwise we are adding an extra 40kb to chromium.

https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5809617

b/352244718

@connorjclark connorjclark requested a review from a team as a code owner August 24, 2024 00:49
@connorjclark connorjclark requested review from adamraine and removed request for a team August 24, 2024 00:49
function runLighthouseNavigation(url, {page, ...options}) {
return navigation(page, url, options);
}

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drive by removal of unused exports

copybara-service bot pushed a commit to ChromeDevTools/devtools-frontend that referenced this pull request Aug 27, 2024
This is already included via the Lighthouse bundle, but
we need this for an insight in RPP. I changed LH to make
this library be injected at runtime, and cherry-pick the
change here in this CL, so as not to add an additional
40 KB (post-compression) to Chromium.

Related LH PR: GoogleChrome/lighthouse#16166

Bug: 352244718
Change-Id: Iafbf8345bedc23038d83723233a55e4f54c4cb05
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5809617
Reviewed-by: Paul Irish <[email protected]>
Commit-Queue: Connor Clark <[email protected]>
@connorjclark connorjclark merged commit 8a2f18a into main Sep 5, 2024
27 checks passed
@connorjclark connorjclark deleted the 3pweb-cdt branch September 5, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants