Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): add types to support permission migration parameters #976

Merged
merged 2 commits into from
Jun 1, 2022

Conversation

bobbrez
Copy link
Contributor

@bobbrez bobbrez commented Jun 1, 2022

CLA

  • I have signed the Stream CLA (required).
  • Code changes are tested

Description of the changes, What, Why and How?

Add support for migrating from legacy permissions (v1) to v2 as per the Migrating from Legacy docs

Changelog

  • fix: add types to support for setting permission_version and migrate_permissions_to_v2 parameters

@AnatolyRugalev
Copy link
Contributor

Hey @bobbrez , thank you for your contribution. Everything looks good to me.

@AnatolyRugalev AnatolyRugalev changed the title Add permission migration types fix(types): add types to support permission migration parameters Jun 1, 2022
@bobbrez
Copy link
Contributor Author

bobbrez commented Jun 1, 2022

@AnatolyRugalev Thanks for fixing the commit message, will be more mindful in future PRs. As for the failing Type Test, it seems to be failing for GetStream/stream-chat-js's master as well.

@AnatolyRugalev
Copy link
Contributor

@bobbrez unfortunately this is how GitHub Actions treat secrets for PRs that are opened from forks. I will go ahead and merge the PR since the failing test shouldn't be a problem

@AnatolyRugalev AnatolyRugalev merged commit 6f82e1a into GetStream:master Jun 1, 2022
@github-actions github-actions bot mentioned this pull request Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants