fix: channel unreadCount to be set as 0 when notification.mark_read event is dispatched [CRNS - 433] #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khushal87
requested review from
peterdeme,
ferhatelmas,
gumuz,
AnatolyRugalev,
vishalnarkhede and
madsroskar
as code owners
|
Size Change: +209 B (0%) Total Size: 285 kB
|
AnatolyRugalev
previously approved these changes
Feb 24, 2022
peterdeme
reviewed
Feb 26, 2022
src/client.ts
Outdated
| @@ -1184,6 +1184,11 @@ export class StreamChat<StreamChatGenerics extends ExtendableGenerics = DefaultG | |||
| this.mutedUsers = event.me.mutes; | |||
| } | |||
|
|
|||
| if (event.type === 'notification.mark_read') { | |||
| const activeChannelKeys = Object.keys(this.activeChannels); | |||
| activeChannelKeys.map((activeChannelKey) => (this.activeChannels[activeChannelKey].state.unreadCount = 0)); | |||
There was a problem hiding this comment.
Shouldn't this be .forEach(activeChannelKey =>?
Suggested change
| activeChannelKeys.map((activeChannelKey) => (this.activeChannels[activeChannelKey].state.unreadCount = 0)); | |
| activeChannelKeys.forEach(activeChannelKey => this.activeChannels[activeChannelKey].state.unreadCount = 0); |
There was a problem hiding this comment.
Yes, that's a better method to handle this case. Thanks, @peterdeme 😄
peterdeme
approved these changes
Feb 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLA
Description of the changes, What, Why, and How?
When we use the markAllRead method, we get the event notification.mark_read, which updates the total_unread_count, but not the channel.state.unreadCount. This PR solved the above issue.
Changelog